Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect filter setting when listening to several servers #2827

Closed
monetdb-team opened this issue Nov 30, 2020 · 0 comments
Closed

Incorrect filter setting when listening to several servers #2827

monetdb-team opened this issue Nov 30, 2020 · 0 comments

Comments

@monetdb-team
Copy link

@monetdb-team monetdb-team commented Nov 30, 2020

Date: 2011-06-29 16:29:35 +0200
From: Milena Ivanova <<M.Ivanova>>
To: clients devs <>
Version: 11.3.3 (Apr2011-SP1) [obsolete]

Last updated: 2011-07-29 10:52:41 +0200

Comment 15859

Date: 2011-06-29 16:29:35 +0200
From: Milena Ivanova <<M.Ivanova>>

When stethoscope listens to multiple servers using a pattern, the <module.function> filter is set incorrectly:

stethoscope -umonetdb -Pmonetdb -p50500 -d "tent*" +stb "octopus."
-- connection with server mapi:monetdb://palu.ins.cwi.nl:50500/tent1 is [1]
-- connection with server mapi:monetdb://palu.ins.cwi.nl:50500/tent2 is [2]
...
-- [1] opened UDP profile stream for palu.ins.cwi.nl:50010
-- [2] opened UDP profile stream for palu.ins.cwi.nl:50011
-- [1] profiler.setFilter("octopus","
");
-- [2] profiler.setFilter("*","octopus");

stethoscope -umonetdb -Pmonetdb -p50500 -d "tent*" +stb "remote.get"
...
-- [2] profiler.setFilter("remote","get");
-- [1] profiler.setFilter("*","remote");

Comment 15870

Date: 2011-07-01 15:53:26 +0200
From: @grobian

Changeset ae0c67221196 made by Fabian Groffen fabian@cwi.nl in the MonetDB repo, refers to this bug.

For complete details, see http//devmonetdborg/hg/MonetDB?cmd=changeset;node=ae0c67221196

Changeset description:

stethoscope: properly set mod.fcn filter for all connections

Fix for bug #2827, when multiple targets are used, the filter would not
be correct for all but the first connection to set the filter.  This
obviously was caused by sharing the same buffer and modifying it.  We
now copy the buffer before modifying it.

Comment 16001

Date: 2011-07-29 10:52:41 +0200
From: @sjoerdmullender

The Apr2011-SP2 bugfix release is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant