Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obsolete conditional HAVE_LIBXML2 still used on Windows #2857

Closed
monetdb-team opened this issue Nov 30, 2020 · 0 comments
Closed

obsolete conditional HAVE_LIBXML2 still used on Windows #2857

monetdb-team opened this issue Nov 30, 2020 · 0 comments

Comments

@monetdb-team
Copy link

@monetdb-team monetdb-team commented Nov 30, 2020

Date: 2011-08-13 12:04:51 +0200
From: @drstmane
To: buildtools devs <>
Version: 11.5.1 (Aug2011) [obsolete]

Last updated: 2011-09-16 15:04:33 +0200

Comment 16098

Date: 2011-08-13 12:04:51 +0200
From: @drstmane

Conditional HAVE_LIBXML2 is no longer used by configure.ag, since we now do require libxml2 to build MonetDB.
However, on Windows the conditional is still used:

.../TestTools $ hg locate | xargs grep --color HAVE_LIBXML2
MdoWin.bat:nmake /nologo "MAKE_INCLUDEFILE=%MAKE_INCLUDEFILE%" "prefix=%WPREFIX_PATH%" bits=%bits% HAVE_GDK=1 HAVE_GEOM=1 HAVE_ICONV=1 HAVE_JAVA=1 HAVE_JAVAJDBC=1 HAVE_LIBBZ2=1 HAVE_LIBXML2=1 HAVE_LIBZ=1 HAVE_MONETDB5=1 HAVE_ODBC=1 HAVE_OPENSSL=1 HAVE_PCRE=1 HAVE_PERL=1 HAVE_PHP=1 HAVE_PYTHON=1 HAVE_RUBYGEM=1 HAVE_SQL=1 HAVE_TESTING=1 %*

.../MonetDB $ hg locate | xargs grep --color HAVE_LIBXML2
NT/monetdb_config.h.in:/* undef HAVE_LIBXML2 */
NT/monetdb_config.h.in:ifdef HAVE_LIBXML2
NT/rules.msc:!IFDEF HAVE_LIBXML2
NT/rules.msc:libxml2_CFLAGS = -DHAVE_LIBXML2 "-I$(LIBXML2)\include" $(zlib_CFLAGS) $(ICONV_CFLAGS)
NT/rules.msc:!IFDEF HAVE_LIBXML2
NT/rules.msc:HAVE_LIBXML2_FALSE=^
NT/rules.msc: "HAVE_LIBXML2_FALSE=$(HAVE_LIBXML2_FALSE)"
buildtools/doc/HowToRelease.rst: HAVE_MONETDB5=1 HAVE_PERL=1 HAVE_LIBXML2=1 HAVE_MONETDB5_XML=1 buildtools/doc/HowToRelease.rst: HAVE_PERL=1 HAVE_LIBXML2=1 HAVE_MONETDB5_XML=1
buildtools/doc/windowsbuild.rst:- HAVE_LIBXML2=1 - the libxml2 library is available;

Comment 16114

Date: 2011-08-20 11:48:54 +0200
From: @drstmane

Changeset 9aeccfbabe43 made by Stefan Manegold Stefan.Manegold@cwi.nl in the MonetDB repo, refers to this bug.

For complete details, see http//devmonetdborg/hg/MonetDB?cmd=changeset;node=9aeccfbabe43

Changeset description:

removed obsolete HAVE_LIBXML2 also on Windows

libxml2 is mandatory for compiling MonetDB(5)
(at least) as of Apr2011;
hence, we remove the obsolete HAVE_LIBXML2
conditional and macro (also) on Windows.

This fixes bug #2857.

Comment 16115

Date: 2011-08-20 11:52:01 +0200
From: @drstmane

Fixed in Aug2011 branch.
No test possible/required.

Comment 16237

Date: 2011-09-16 15:04:33 +0200
From: @sjoerdmullender

The Aug2011 version has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant