Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test monetdb5/optimizer/Tests/dataflow.mal fails on all Windows & Solaris (only) #2866

Closed
monetdb-team opened this issue Nov 30, 2020 · 0 comments
Labels

Comments

@monetdb-team
Copy link

@monetdb-team monetdb-team commented Nov 30, 2020

Date: 2011-08-24 07:25:20 +0200
From: @drstmane
To: MonetDB5 devs <>
Version: 11.5.1 (Aug2011) [obsolete]
CC: @mlkersten, @yzchang

Last updated: 2012-11-27 14:48:51 +0100

Comment 16153

Date: 2011-08-24 07:25:20 +0200
From: @drstmane

Test monetdb5/optimizer/Tests/dataflow.mal fails on all Windows & Solaris platforms of nightly testing, while working fine on all other platforms; cf., e.g.,

http://monetdb.cwi.nl/testweb/web/testgrid.php?serial=41503:fa813932a753&module=monetdb5&targets=GNU-Solaris-sparc,GNU-Solaris-sparcv9-oid32,GNU-Solaris-sparcv9,Int-WindowsXP-i386-propcheck,Mic-Windows2008-i386-propcheck-installer,Int-Windows7-x86_64-propcheck-oid32,Mic-Windows7-x86_64-propcheck-oid32-installer,Int-Windows2008-x86_64-propcheck,Mic-Windows2008-x86_64-propcheck-installer&order=platform,arch,compiler

Comment 16158

Date: 2011-08-24 07:53:42 +0200
From: @mlkersten

The point select is different between the two tests. This may indicate that the random number generator produced different results. Test expanded with explicit random seed.

Comment 16161

Date: 2011-08-24 22:38:34 +0200
From: @drstmane

Unfortunately, seeding the random number generator does not help; cf.,

http://monetdb.cwi.nl/testweb/web/testgrid.php?serial=41578:0dc2371c2a9c&module=monetdb5&targets=GNU-Solaris-sparc,GNU-Solaris-sparcv9-oid32,GNU-Solaris-sparcv9,Int-WindowsXP-i386-propcheck,Mic-Windows2008-i386-propcheck-installer,Int-Windows7-x86_64-propcheck-oid32,Mic-Windows7-x86_64-propcheck-oid32-installer,Int-Windows2008-x86_64-propcheck,Mic-Windows2008-x86_64-propcheck-installer&order=platform,arch,compiler

Apparently, the random number generators on Solaris & Windows work differently than on other systems.
If despite the different random numbers and different behavior still tests what it's intended to test, we could consider approving specific output for Windows & Solaris (hope the behavior will remain deterministic over time).
Otherwise, we should consider redesigning the test without using mmath.rand().

Comment 16178

Date: 2011-08-27 22:44:55 +0200
From: @drstmane

The test now appears to work fine on all platforms.

Comment 16234

Date: 2011-09-16 15:04:31 +0200
From: @sjoerdmullender

The Aug2011 version has been released.

Comment 18096

Date: 2012-11-27 14:48:51 +0100
From: @yzchang

This is about existing tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant