Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database upgrade with SQL catalog upgrade messes up privileges #2934

Closed
monetdb-team opened this issue Nov 30, 2020 · 0 comments
Closed

Database upgrade with SQL catalog upgrade messes up privileges #2934

monetdb-team opened this issue Nov 30, 2020 · 0 comments

Comments

@monetdb-team
Copy link

@monetdb-team monetdb-team commented Nov 30, 2020

Date: 2011-12-05 16:28:28 +0100
From: @sjoerdmullender
To: SQL devs <>
Version: 11.7.5 (Dec2011) [obsolete]

Last updated: 2012-01-26 15:32:06 +0100

Comment 16582

Date: 2011-12-05 16:28:28 +0100
From: @sjoerdmullender

User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.24) Gecko/20111108 Fedora/3.6.24-1.fc14 Firefox/3.6.24
Build Identifier:

Yet another blocker for a release.

Reproducible: Always

Steps to Reproduce:

1.create database using Aug2011 release (e.g. SP3)
2.(maybe insert some data)
3.stop server, upgrade to Dec2011, start server
4.create new user with new schema, set schema to be default for user
5.select * from sys.tables;

Actual Results:

SELECT: access denied for testuser to table 'sys.tables'

Expected Results:

Contents of sys.tables.

I used my "testdb.sql" script after the upgrade. It creates a user with a default schema.

Without an upgrade, things work as expected. In both branches.

Comment 16634

Date: 2011-12-08 16:03:18 +0100
From: @sjoerdmullender

Changeset 8f99f0ff2208 made by Sjoerd Mullender sjoerd@acm.org in the MonetDB repo, refers to this bug.

For complete details, see http//devmonetdborg/hg/MonetDB?cmd=changeset;node=8f99f0ff2208

Changeset description:

After destroying and recreating sys.columns and sys.tables, add privileges.
This fixes bug #2934.
The problem: during an catalog upgrade, sys.columns and sys.tables are
dropped and recreated (in case they changed).  The new versions of
these views were not represented in the sys.privileges table.  We now
add entries for the new views, solving the bug.

Comment 16635

Date: 2011-12-08 16:06:17 +0100
From: @sjoerdmullender

Bug has been fixed.
No test added since we don't yet have a way to test upgrades.
The summary is changed since this bug actually occurred in many previous releases but was never noticed.

Comment 16830

Date: 2012-01-26 15:32:06 +0100
From: @sjoerdmullender

The Dec2011 version has been release, so declaring this bug as FIXED.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant