Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

joinPath runs indeterminately #2965

Closed
monetdb-team opened this issue Nov 30, 2020 · 0 comments
Closed

joinPath runs indeterminately #2965

monetdb-team opened this issue Nov 30, 2020 · 0 comments

Comments

@monetdb-team
Copy link

@monetdb-team monetdb-team commented Nov 30, 2020

Date: 2012-01-04 20:32:44 +0100
From: Babis <>
To: MonetDB5 devs <>
Version: 11.7.5 (Dec2011) [obsolete]
CC: @mlkersten, @yzchang

Last updated: 2012-11-27 14:19:26 +0100

Comment 16744

Date: 2012-01-04 20:32:44 +0100
From: Babis <>

User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_2) AppleWebKit/534.52.7 (KHTML, like Gecko) Version/5.1.2 Safari/534.52.7
Build Identifier:

Executing a naive algebra.joinPath on three BATs does not terminate. CPU usage is at 100%.

Reproducible: Always

Steps to Reproduce:

  1. Run mserver5
  2. Paste the following series of MAL commands
    a:bat[:oid, :int] := bat.new(:oid, :int);
    b:bat[:oid, :int] := bat.new(:oid, :int);
    c:bat[:oid, :int] := bat.new(:oid, :int);
    bat.append(a, 1);
    bat.append(a, 2);
    bat.append(a, 3);
    bat.append(b, 1);
    bat.append(b, 2);
    bat.append(b, 0);
    bat.append(c, 0);
    bat.append(c, 3);
    bat.append(c, 1);
    algebra.joinPath(a, b, c);

Run on Ubuntu Linux and Mac OS X both using a 64bit architecture CPU.

Comment 16745

Date: 2012-01-04 21:58:27 +0100
From: @mlkersten

The joinpath optimizer should have complained about a typing error.

Comment 16746

Date: 2012-01-04 22:30:55 +0100
From: @mlkersten

Changeset fa4034576f02 made by Martin Kersten mk@cwi.nl in the MonetDB repo, refers to this bug.

For complete details, see http//devmonetdborg/hg/MonetDB?cmd=changeset;node=fa4034576f02

Changeset description:

Fix for bug #2965
Typechecking should be included as extra defense line.
Furthermore, we need to remove reference counts during
error handling.

Comment 16747

Date: 2012-01-04 22:31:42 +0100
From: @mlkersten

Code has been extended with type checking in ALGjoinPathZZ

Comment 16748

Date: 2012-01-05 13:14:35 +0100
From: @mlkersten

Changeset 3216c175f19c made by Martin Kersten mk@cwi.nl in the MonetDB repo, refers to this bug.

For complete details, see http//devmonetdborg/hg/MonetDB?cmd=changeset;node=3216c175f19c

Changeset description:

Fix for bug #2965
Typechecking should be included as extra defense line.
Furthermore, we need to remove reference counts during
error handling.
(transplanted from fa4034576f02bf1a1aa3a755852b021d8da1540b)

Comment 16749

Date: 2012-01-05 16:25:48 +0100
From: @sjoerdmullender

Changeset 7a5d896c4c2a made by Sjoerd Mullender sjoerd@acm.org in the MonetDB repo, refers to this bug.

For complete details, see http//devmonetdborg/hg/MonetDB?cmd=changeset;node=7a5d896c4c2a

Changeset description:

Added test for bug #2965.

Comment 16757

Date: 2012-01-08 13:09:31 +0100
From: @drstmane

Changeset 3ee6c9d194f6 made by Stefan Manegold Stefan.Manegold@cwi.nl in the MonetDB repo, refers to this bug.

For complete details, see http//devmonetdborg/hg/MonetDB?cmd=changeset;node=3ee6c9d194f6

Changeset description:

ALGjoinPath: refined fix for bug #2965 (type check)

While algebra.join() allows only joins on equal types,
and opt_joinpath only recognizes joins on equal types,
algebra.joinpath() did allow joins on equal storage types.

With this checkin, also algebra.joinpath() allows only
joins on equal types.

This should make test monetdb5/tests/BugTracker/Tests/joinpath-loop.Bug-2965
work as intended also with 32-bit OIDs.
The test tries to trigger a type mismatch exception with
algebra.joinpath() by tyring to join int with oid.
This attempt failed, i.e., the exception was not triggered,
with 32-bit OIDs, as 32-bit OIDs have the same storage type
as (32-bit) int.
Cf.,
http://monetdb.cwi.nl/testweb/web/testgrid.php?serial=42715:298eda2b30da&module=monetdb5
http://monetdb.cwi.nl/testweb/tests/42715:298eda2b30da/GNU-Darwin-i386-propcheck/monetdb5/mTests/tests/BugTracker/joinpath-loop.Bug-2965.out.diff.html

Comment 16815

Date: 2012-01-26 15:31:56 +0100
From: @sjoerdmullender

The Dec2011 version has been release, so declaring this bug as FIXED.

Comment 18077

Date: 2012-11-27 14:19:26 +0100
From: @yzchang

Test already added in monetdb5/tests/BugTracker/Tests/joinpath-loop.Bug-2965

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant