Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL URL functionality contains errors #2972

Closed
monetdb-team opened this issue Nov 30, 2020 · 0 comments
Closed

SQL URL functionality contains errors #2972

monetdb-team opened this issue Nov 30, 2020 · 0 comments

Comments

@monetdb-team
Copy link

@monetdb-team monetdb-team commented Nov 30, 2020

Date: 2012-01-14 13:23:06 +0100
From: @mlkersten
To: SQL devs <>
Version: 11.21.11 (Jul2015-SP1)
CC: joerg.strebel, @njnes

Last updated: 2016-03-25 09:59:37 +0100

Comment 16771

Date: 2012-01-14 13:23:06 +0100
From: @mlkersten

User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:9.0.1) Gecko/20100101 Firefox/9.0.1
Build Identifier: Dec2011

The URL data type and operations are incomplete.
In particular, when the script url_script_test is ran completely
as
mserver5 --dbinit()="sql.start();" url_script_test.sql
...
% newurl_single_value name
% url type
% 28 length
[ "://www.monetdb.org:8080/blah" ]

which should have produced
[ "https://www.monetdb.org:8080/blah" ]

Reproducible: Always

Test file has been added, pending further investigation

Comment 16774

Date: 2012-01-14 14:12:15 +0100
From: @drstmane

Changeset fdc3b8b379f8 made by Stefan Manegold Stefan.Manegold@cwi.nl in the MonetDB repo, refers to this bug.

For complete details, see http//devmonetdborg/hg/MonetDB?cmd=changeset;node=fdc3b8b379f8

Changeset description:

renamed new tests to include bug report id in test name:
url_script_test.sql -> url_script_test.Bug-2972.sql
date_script_test.sql -> date_script_test.Bug-2973.sql

this simplies linking tests to bug reports and vice versa

Comment 16776

Date: 2012-01-14 14:16:14 +0100
From: @drstmane

Changeset 49f931f6754f made by Stefan Manegold Stefan.Manegold@cwi.nl in the MonetDB repo, refers to this bug.

For complete details, see http//devmonetdborg/hg/MonetDB?cmd=changeset;node=49f931f6754f

Changeset description:

added skeleton stable output for tests url_script_test.Bug-2972 & date_script_test.Bug-2973

correct / expected output still needs to be verified and approved

Comment 16805

Date: 2012-01-20 15:53:36 +0100
From: @sjoerdmullender

When I try the test, I do get the expected result (https://www.monetdb.org:8080/blah). I also see that this result on the testweb.

Comment 17134

Date: 2012-04-18 15:13:55 +0200
From: @grobian

Changeset adc577be86a4 made by Fabian Groffen fabian@cwi.nl in the MonetDB repo, refers to this bug.

For complete details, see http//devmonetdborg/hg/MonetDB?cmd=changeset;node=adc577be86a4

Changeset description:

open_urlstream: provide file:// implementation without cURL

For Windows (and other systems), where we don't have cURL, check if the
URL happens to be a file:// URL, and fall back to a regular ASCII stream
in that case.  This should allow url_script_test.Bug-2972 test to come a
little bit further on Windows.

Comment 17226

Date: 2012-05-07 13:52:54 +0200
From: @njnes

seems okay on linux, still broken on windows

Comment 17244

Date: 2012-05-09 17:02:13 +0200
From: @njnes

output wasn't stable because of incorrect NIL checking, this is fixed now.

Comment 17401

Date: 2012-07-03 12:56:41 +0200
From: @sjoerdmullender

Changeset 5aebbb6f96b0 made by Sjoerd Mullender sjoerd@acm.org in the MonetDB repo, refers to this bug.

For complete details, see http//devmonetdborg/hg/MonetDB?cmd=changeset;node=5aebbb6f96b0

Changeset description:

Make that sql test BugTracker-2012/url_script_test.Bug-2972 works on Windows.
This involves creating a special environment variable within Mtest
called UTSTSRCDIR which is the file: URL version of TSTSRCDIR, and
fixing the non-cURL implementation of open_urlstream to skip all
slashes that are part of a file: url on Windows.

Comment 21720

Date: 2016-01-08 18:48:48 +0100
From: Jörg Strebel <<joerg.strebel>>

The test url_script_test.Bug-2972.sql.in contains the line:

insert into t2972 values ('$UTSTSRCDIR/url_script_test.Bug-2972.txt');

The Mtest script creates the following SQL statement:

insert into t2972 values ('file:/home/jstrebel/devel/MonetDB-Jul2015/MonetDB/sql/test/BugTracker-2012/Tests/url_script_test.Bug-2972.txt');

This table entry then makes the following "select getcontent(u) from t2972" throw an error (ERROR = !failed to open urlstream), as the double slashes after the colon are missing.
With the double slashes in the url (file:///home...), getcontent() works nicely.

Comment 21924

Date: 2016-03-16 18:49:22 +0100
From: @njnes

added the additional //.

Comment 21970

Date: 2016-03-25 09:59:37 +0100
From: @sjoerdmullender

Jul2015-SP3 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant