Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dayofweek comment is wrong in mtime.mx:700 #3014

Closed
monetdb-team opened this issue Nov 30, 2020 · 0 comments
Closed

dayofweek comment is wrong in mtime.mx:700 #3014

monetdb-team opened this issue Nov 30, 2020 · 0 comments
Labels

Comments

@monetdb-team
Copy link

@monetdb-team monetdb-team commented Nov 30, 2020

Date: 2012-02-15 22:25:55 +0100
From: @skinkie
To: MonetDB5 devs <>
Version: -- development
CC: @yzchang, yadavtheddie007

Last updated: 2018-10-23 19:14:06 +0200

Comment 16894

Date: 2012-02-15 22:25:55 +0100
From: @skinkie

User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/535.1 (KHTML, like Gecko) Chrome/14.0.835.159 Safari/535.1
Build Identifier:

monetdb5/modules/atoms/mtime.mx:700
command dayofweek(d:date) :int
address MTIMEdate_extract_dayofweek
comment "Returns the current day of the week
where 1=sunday, .., 7=saturday";

Opposed to the implementation at mtime.mx:2247

/* Returns the current day of the week where 1=monday, .., 7=sunday */
static inline str
date_extract_dayofweek(int *ret, date *v)
{
if (*v == date_nil) {
*ret = int_nil;
} else {
*ret = date_dayofweek(*v);
}
return MAL_SUCCEED;
}

Reproducible: Always

Comment 16912

Date: 2012-02-16 14:55:49 +0100
From: @sjoerdmullender

Changeset f745ed170259 made by Sjoerd Mullender sjoerd@acm.org in the MonetDB repo, refers to this bug.

For complete details, see http//devmonetdborg/hg/MonetDB?cmd=changeset;node=f745ed170259

Changeset description:

Fixed comment.
This fixes bug #3014.

Comment 18074

Date: 2012-11-27 14:14:05 +0100
From: @yzchang

No need to test code comments

Comment 26652

Date: 2018-10-23 19:14:06 +0200
From: adv ydv <>

we get enjoy the many types games http://tanktrouble.xyz but some time ago my friends are suggest him. then we are play. this is the unforgettable movements in my life

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant