Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimizer tests fail with new optimizer framework #3030

Closed
monetdb-team opened this issue Nov 30, 2020 · 0 comments
Closed

optimizer tests fail with new optimizer framework #3030

monetdb-team opened this issue Nov 30, 2020 · 0 comments

Comments

@monetdb-team
Copy link

@monetdb-team monetdb-team commented Nov 30, 2020

Date: 2012-02-20 00:36:45 +0100
From: @drstmane
To: SQL devs <>
Version: -- development
CC: @mlkersten

Last updated: 2012-04-27 14:51:58 +0200

Comment 16952

Date: 2012-02-20 00:36:45 +0100
From: @drstmane

Optimizer tests
sql/backends/monet5/Tests/optimizers.sql
and
sql/test/Tests/setoptimizer.sql
fail with the new optimizer framework.

In particular the following error messages seem to be unexpected:

!SyntaxException:parseError:
!';' expected

Cf.,
http://monetdb.cwi.nl/testweb/tests/43229:ef8a1eddc090/GNU-Fedora-x86_64-propcheck-assert/sql/mTests/test/setoptimizer.out.diff.html
http://monetdb.cwi.nl/testweb/tests/43229:ef8a1eddc090/GNU-Fedora-x86_64-propcheck-assert/sql/mTests/backends/monet5/optimizers.out.diff.html
http://monetdb.cwi.nl/testweb/tests/43229:ef8a1eddc090/GNU-Fedora-x86_64-propcheck-assert/sql/mTests/backends/monet5/optimizers.err.diff.html

Comment 16971

Date: 2012-02-22 16:40:51 +0100
From: @drstmane

See also bug #3037 .

Comment 17027

Date: 2012-02-29 00:49:39 +0100
From: @drstmane

Updated URLs:

http://monetdb.cwi.nl/testweb/tests/43369:9a4896bf69ea/GNU-Fedora-x86_64-propcheck-assert/sql/mTests/backends/monet5/optimizers.err.diff.html

http://monetdb.cwi.nl/testweb/tests/43369:9a4896bf69ea/GNU-Fedora-x86_64-propcheck-assert/sql/mTests/test/setoptimizer.err.diff.html

The remaining differences / bugs are

The expected error
"
ERROR = !Syntax error detected.See documentation for details
"
now looks like
"
ERROR = !SyntaxException:parseError:
!';' expected
!Syntax error detected.See documentation for details
"
(if this is indeed intended, then we need to approve the new error message)

These errors are unexpected and wrong:
"
QUERY = select optimizer;
ERROR = !SyntaxException:parseError:
!';' expected
"
Maybe "just" a non-cleared error message buffer after the above error?

Comment 17029

Date: 2012-02-29 08:47:38 +0100
From: @mlkersten

first error is indeed as expected.
second error is indeed an open issue

Comment 17032

Date: 2012-02-29 15:19:29 +0100
From: @drstmane

Since changeset 0b6fc034c39c (http://dev.monetdb.org/hg/MonetDB/rev/0b6fc034c39c),
test sql/backends/monet5/Tests/optimizers.sql results in a crash (segfault).

Comment 17035

Date: 2012-03-01 10:33:21 +0100
From: @drstmane

segfault appears to be fixed. thanks.

latest status is available at, e.g.,

http://monetdb.cwi.nl/testweb/tests/43387:6b7b9ede06dd/GNU-Fedora-x86_64-propcheck-assert/sql/mTests/test/setoptimizer.out.diff.html

http://monetdb.cwi.nl/testweb/tests/43387:6b7b9ede06dd/GNU-Fedora-x86_64-propcheck-assert/sql/mTests/test/setoptimizer.err.diff.html

http://monetdb.cwi.nl/testweb/tests/43387:6b7b9ede06dd/GNU-Fedora-x86_64-propcheck-assert/sql/mTests/backends/monet5/optimizers.err.diff.html

Comment 17049

Date: 2012-03-06 18:08:11 +0100
From: @sjoerdmullender

Changeset fe6468cef2b0 made by Sjoerd Mullender sjoerd@acm.org in the MonetDB repo, refers to this bug.

For complete details, see http//devmonetdborg/hg/MonetDB?cmd=changeset;node=fe6468cef2b0

Changeset description:

When set optimizer fails, don't change old value.
It seems reasonable to me to not change the value of the SQL optimizer
variable if there is an error setting it.  This also means not
changing the optimizers() table.
Also approved new error messages.
This fixes bug #3030.

Comment 17175

Date: 2012-04-27 01:19:06 +0200
From: @drstmane

This appears to be fixed in Apr2012_1 and Apr2012 (latest):

http://monetdb.cwi.nl/testweb/web/testgrid.php?serial=43870:4702495ed780&module=sql

http://monetdb.cwi.nl/testweb/web/testgrid.php?serial=43950:702b55cbad26&module=sql

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant