Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php driver uses call-time pass-by-reference #3169

Closed
monetdb-team opened this issue Nov 30, 2020 · 0 comments
Closed

php driver uses call-time pass-by-reference #3169

monetdb-team opened this issue Nov 30, 2020 · 0 comments

Comments

@monetdb-team
Copy link

@monetdb-team monetdb-team commented Nov 30, 2020

Date: 2012-10-23 14:50:18 +0200
From: @grobian
To: clients devs <>
Version: 11.13.3 (Oct2012)
CC: @hannesmuehleisen

Last updated: 2013-01-22 09:29:19 +0100

Comment 17851

Date: 2012-10-23 14:50:18 +0200
From: @grobian

on PHP 5.4:

Fatal error: Call-time pass-by-reference has been removed
in /usr/local/monetdb/share/php/monetdb/php_monetdb.php on line 302

Comment 18079

Date: 2012-11-27 14:25:04 +0100
From: @hannesmuehleisen

From http://nl1.php.net/manual/en/language.references.pass.php :

"Note: There is no reference sign on a function call - only on function definitions. Function definitions alone are enough to correctly pass the argument by reference. As of PHP 5.3.0, you will get a warning saying that "call-time pass-by-reference" is deprecated when you use & in foo(&$a);. And as of PHP 5.4.0, call-time pass-by-reference was removed, so using it will raise a fatal error."

Hence,

if (($row_array = monetdb_fetch_assoc(&$hdl, $row)) == FALSE) {

was changed to

if (($row_array = monetdb_fetch_assoc($hdl, $row)) == FALSE) {

in revision :03ae7968ce97

Tested and found to be effective using PHP 5.4.9

Comment 18198

Date: 2012-11-28 13:45:31 +0100
From: @hannesmuehleisen

Changeset ac97c97f512e made by Hannes Muehleisen hannes@cwi.nl in the MonetDB repo, refers to this bug.

For complete details, see http//devmonetdborg/hg/MonetDB?cmd=changeset;node=ac97c97f512e

Changeset description:

Fixed PHP client to no longer produce a fatal error in PHP 5.4 - Bug #3169

Comment 18385

Date: 2013-01-22 09:29:19 +0100
From: @sjoerdmullender

Oct2012-SP3 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant