Storage of client history

[monetdb-team]

Date: 2012-11-19 14:01:56 +0100
From: @skinkie
To: Stefan de Konink <>
Version: 11.13.3 (Oct2012)

Last updated: 2013-01-22 09:29:15 +0100

Comment 17950

Date: 2012-11-19 14:01:56 +0100
From: @skinkie

User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.17 (KHTML, like Gecko) Chrome/24.0.1312.14 Safari/537.17
Build Identifier:

The current client does not seem to store history anymore. Neither with -H or --history. The last time we discussed this issue there was a porblem detecting something in the configure phase. As far as I can see readline is installed, so I wonder what other things might be missing.

sys-libs/readline-6.2_p1-r1

It would be valuable to remove the help option if the configuration would prevent the storage at all.

Reproducible: Always

Comment 17987

Date: 2012-11-22 13:58:01 +0100
From: @grobian

Are you on Oct2012 or on default? In the latter case, we might have introduced a bug when we did some moving of code around in mclient.

Comment 17988

Date: 2012-11-22 13:58:27 +0100
From: @skinkie

Oct2012.

Comment 18026

Date: 2012-11-27 11:03:14 +0100
From: @sjoerdmullender

What is your OS/distribution and version?
What version of MonetDB are you using (binary release, self-compiled)?
The history works for me so it may have something to do with that.

Comment 18028

Date: 2012-11-27 11:24:01 +0100
From: @skinkie

(In reply to comment 3)

What is your OS/distribution and version?
What version of MonetDB are you using (binary release, self-compiled)?
The history works for me so it may have something to do with that.

Gentoo Linux latest unstable
Selfcompiled Oct2012

I do remember Fabian and me tested something the last time, but I don't know what.

Comment 18166

Date: 2012-11-27 23:25:27 +0100
From: @skinkie

Created attachment 160
Fix to create the initial history file.

The problem is occurs if you don't have a .mapiclient_history_sql in the homedir. Why is this a problem? Because append_history is called from add_history. Append history will set the overwrite=0 argument in history_do_write, which causes the file mode to get O_WRONLY|O_APPEND|O_BINARY opposed to O_WRONLY|O_CREAT|O_TRUNC|O_BINARY.

I am glad I could be part of bugday!

Attached file: fix-mapiclient-history-creation.patch (text/plain, 471 bytes)
Description: Fix to create the initial history file.

Comment 18239

Date: 2012-12-05 15:58:15 +0100
From: @sjoerdmullender

Changeset 86c18d07007c made by Sjoerd Mullender sjoerd@acm.org in the MonetDB repo, refers to this bug.

For complete details, see http//devmonetdborg/hg/MonetDB?cmd=changeset;node=86c18d07007c

Changeset description:

Create history file if it didn't exist.
Obviously only when the user requested history be saved.
This fixes bug #3188.

Comment 18240

Date: 2012-12-05 15:58:51 +0100
From: @sjoerdmullender

A slightly different fix has been checked in.

Comment 18317

Date: 2013-01-04 12:17:28 +0100
From: @skinkie

The first time a client tries to save history there is a warning now:

"Warning: not saving history"

While the second time the message is gone. I don't know if this is intended.

Comment 18377

Date: 2013-01-22 09:29:15 +0100
From: @sjoerdmullender

Oct2012-SP3 has been released.