Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"unknown property" error setting format and width in .monetdb file #3216

Closed
monetdb-team opened this issue Nov 30, 2020 · 0 comments
Closed

"unknown property" error setting format and width in .monetdb file #3216

monetdb-team opened this issue Nov 30, 2020 · 0 comments

Comments

@monetdb-team
Copy link

@monetdb-team monetdb-team commented Nov 30, 2020

Date: 2013-01-07 04:22:37 +0100
From: Patrick TJ McPhee <>
To: clients devs <>
Version: 11.13.7 (Oct2012-SP2)

Last updated: 2013-02-19 13:17:57 +0100

Comment 18318

Date: 2013-01-07 04:22:37 +0100
From: Patrick TJ McPhee <>

User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.1.4) Gecko/20091114 Firefox/3.5.4
Build Identifier:

If you create a .monetdb file with a width setting, e.g.,

width=-1

mclient gives this error message:

.monetdb:1: unknown property: width

The setting actually works, but the error message appears on the screen. The same happens for format.

I have a patch that fixes it (and also adds a database parameter in case you'd care to do that :).

Reproducible: Always

Steps to Reproduce:

  1. add width= to .monetdb
  2. start mclient

Actual Results:

.monetdb:1: unknown property: width

is displayed

Expected Results:

For nothing to be displayed.

I've observed this on Linux, NetBSD, and FreeBSD, but it should be an issue on all platforms. This patch resolves the issue. It also adds a database parameter

--- mclient.c.orig 2012-12-12 07:00:35.000000000 -0500
+++ mclient.c 2013-01-06 21:54:46.000000000 -0500
@@ -2788,9 +2788,14 @@
}
} else if (strcmp(buf, "format") == 0) {
output = strdup(q);

  •                           q = NULL;
    
  •                   } else if (strcmp(buf, "database") == 0) {
    
  •                           dbname = strdup(q);     /* leak */
    
  •                           q = NULL;
                      } else if (strcmp(buf, "width") == 0) {
                              pagewidth = atoi(q);
                              pagewidthset = pagewidth != 0;
    
  •                           q = NULL;
                      }
                      if (q != NULL)
                              mnstr_printf(stderr_stream,
    

Comment 18319

Date: 2013-01-07 04:25:10 +0100
From: Patrick TJ McPhee <>

Created attachment 167
Patch to mclient which resolves the issue, and adds a database parameter

Attached file: mclient.patch (text/plain, 567 bytes)
Description: Patch to mclient which resolves the issue, and adds a database parameter

Comment 18336

Date: 2013-01-15 16:14:23 +0100
From: @sjoerdmullender

This bug occurs to the Oct2012 branch only. It does not occur in the Feb2013 branch.

Comment 18509

Date: 2013-02-19 13:17:57 +0100
From: @sjoerdmullender

Feb2013 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant