Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdk_posix fails to compile under NetBSD #3217

Closed
monetdb-team opened this issue Nov 30, 2020 · 0 comments
Closed

gdk_posix fails to compile under NetBSD #3217

monetdb-team opened this issue Nov 30, 2020 · 0 comments

Comments

@monetdb-team
Copy link

@monetdb-team monetdb-team commented Nov 30, 2020

Date: 2013-01-07 05:17:50 +0100
From: Patrick TJ McPhee <>
To: GDK devs <>
Version: 11.13.9 (Oct2012-SP3)

Last updated: 2013-03-08 08:44:34 +0100

Comment 18320

Date: 2013-01-07 05:17:50 +0100
From: Patrick TJ McPhee <>

User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.1.4) Gecko/20091114 Firefox/3.5.4
Build Identifier:

On NetBSD, the defines HAVE_KVM_H and HAVE_SYS_SYSCTL_H are defined, which drops the code into the FreeBSD KVM code for returning RSS, but NetBSD's implementation is not compatible.

I'll attach a patch which allows it to compile. I've only tried this on NetBSD 6, amd64.

Reproducible: Always

Steps to Reproduce:

  1. run configure
  2. run gmake

Actual Results:

libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -I. -I../common/options -I./../common/options -I../common/stream -I./../common/stream -I../common/utils -I./../common/utils -I/usr/pkg/include -DLIBGDK -O3 -fomit-frame-pointer -pipe -Wp,-D_FORTIFY_SOURCE=2 -D_REENTRANT -c gdk_posix.c -fPIC -DPIC -o .libs/libbat_la-gdk_posix.o
gdk_posix.c: In function 'MT_getrss':
gdk_posix.c:326:10: error: 'struct kinfo_proc' has no member named 'ki_rssize'

Expected Results:

No compilation error.

Comment 18321

Date: 2013-01-07 05:19:28 +0100
From: Patrick TJ McPhee <>

Created attachment 168
Patch which allows gdk_posix.c to compile under NetBSD 6

Attached file: netbsd-gdk.patch (text/plain, 344 bytes)
Description: Patch which allows gdk_posix.c to compile under NetBSD 6

Comment 18335

Date: 2013-01-15 16:03:13 +0100
From: @sjoerdmullender

Changeset 9880ae072539 made by Sjoerd Mullender sjoerd@acm.org in the MonetDB repo, refers to this bug.

For complete details, see http//devmonetdborg/hg/MonetDB?cmd=changeset;node=9880ae072539

Changeset description:

Make compilable on NetBSD.
This should fix bug #3217.  Thanks to Patrick TJ McPhee.

Comment 18441

Date: 2013-01-29 10:16:58 +0100
From: @sjoerdmullender

I'm assuming that this is now resolved. Please reopen if that is not the case.
The fix didn't make it to the Oct2012-SP3 release, but should be in the next release.

Comment 18508

Date: 2013-02-19 13:17:56 +0100
From: @sjoerdmullender

Feb2013 has been released.

Comment 18596

Date: 2013-03-08 06:33:43 +0100
From: Patrick TJ McPhee <>

Confirmed this worked with Feb2013 and Feb2013 sp1.

Comment 18597

Date: 2013-03-08 08:44:34 +0100
From: @sjoerdmullender

Thanks for verifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant