Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name of coercions optimizer wrong in opt_wrapper.c #3251

Closed
monetdb-team opened this issue Nov 30, 2020 · 0 comments
Closed

Name of coercions optimizer wrong in opt_wrapper.c #3251

monetdb-team opened this issue Nov 30, 2020 · 0 comments

Comments

@monetdb-team
Copy link

@monetdb-team monetdb-team commented Nov 30, 2020

Date: 2013-03-11 00:32:30 +0100
From: Pete Hollobon <>
To: MonetDB5 devs <>
Version: 11.15.3 (Feb2013-SP1)
CC: @mlkersten, pete, @drstmane

Last updated: 2013-04-29 14:51:29 +0200

Comment 18602

Date: 2013-03-11 00:32:30 +0100
From: Pete Hollobon <>

The name of the coercions optimizer is wrong in opt_wrapper.c, so it's never used, despite being in several of the optimizer pipelines.

Here's patch

--- a/monetdb5/optimizer/opt_wrapper.c
+++ b/monetdb5/optimizer/opt_wrapper.c
@@ -84,7 +84,7 @@
{"aliases", &OPTaliasesImplementation},
{"centipede", &OPTcentipedeImplementation},
{"cluster", &OPTclusterImplementation},

  •   {"coercion", &OPTcoercionImplementation},
    
  •   {"coercions", &OPTcoercionImplementation},
      {"commonTerms", &OPTcommonTermsImplementation},
      {"compression", &OPTcompressionImplementation},
      {"costModel", &OPTcostModelImplementation},
    

Comment 18610

Date: 2013-03-12 03:17:49 +0100
From: @drstmane

Changeset 30c2d470a73d made by Stefan Manegold Stefan.Manegold@cwi.nl in the
MonetDB repo, refers to this bug.

For complete details, see
http//devmonetdborg/hg/MonetDB?cmd=changeset;node=30c2d470a73d

Changeset description:

 opt_support.c & opt_wrapper.c: "coercion" -> "coercions",
 i.e., using the correct optimizer name "coercions"
 to ensure the optimizer is indeed activated/used.

 Approved related changes in test output (modified MAL plans
 due to now active coercions optimizer).

 This should fix bug #3251.

 Thanks to Pete Hollobon for reporting and proving the initial fix!


 Open question:

 Why is an incorrect / non-exiting optimizer name silently ignored??

Comment 18625

Date: 2013-03-18 08:28:15 +0100
From: @mlkersten

Exception is thrown when the optimizer does not exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant