Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M5 tests inlineFunction & ifthencst fail since changeset 207ed7d7e03a #3255

Closed
monetdb-team opened this issue Nov 30, 2020 · 0 comments
Closed

M5 tests inlineFunction & ifthencst fail since changeset 207ed7d7e03a #3255

monetdb-team opened this issue Nov 30, 2020 · 0 comments

Comments

@monetdb-team
Copy link

@monetdb-team monetdb-team commented Nov 30, 2020

Date: 2013-03-12 23:22:46 +0100
From: @drstmane
To: MonetDB5 devs <>
Version: 11.15.11 (Feb2013-SP3)
CC: @mlkersten

Last updated: 2013-09-27 13:47:18 +0200

Comment 18615

Date: 2013-03-12 23:22:46 +0100
From: @drstmane

In the Feb2013 branch, tests

monetdb5/optimizer/Tests/inlineFunction.mal
and
monetdb5/optimizer/Tests/ifthencst.mal

fail since changeset 207ed7d7e03a
(cf. http://dev.monetdb.org/hg/MonetDB/rev/207ed7d7e03a)
as the optimizer(s) now seem to produce different output / MAL plans;

see also
http://monetdb.cwi.nl/testweb/web/showtestoutput.php?serial=46925:1a234210f142&target=GNU-Fedora-x86_64-propcheck-assert&module=monetdb5&test=monetdb5%2Foptimizer%2FinlineFunction&which=out
http://monetdb.cwi.nl/testweb/web/showtestoutput.php?serial=46925:1a234210f142&target=GNU-Fedora-x86_64-propcheck-assert&module=monetdb5&test=monetdb5%2Foptimizer%2Fifthencst&which=out
http://monetdb.cwi.nl/testweb/web/testchange.php?test=46925:1a234210f142/GNU-Fedora-x86_64-propcheck-assert/monetdb5/mTests/monetdb5%2Foptimizer%2FinlineFunction
http://monetdb.cwi.nl/testweb/web/testchange.php?test=46925:1a234210f142/GNU-Fedora-x86_64-propcheck-assert/monetdb5/mTests/monetdb5%2Foptimizer%2Fifthencst
http://monetdb.cwi.nl/testweb/web/testchange.php?test=46925:1a234210f142/GNU-Fedora-x86_64-propcheck-assert/monetdb5/mTests/optimizer%2FinlineFunction
http://monetdb.cwi.nl/testweb/web/testchange.php?test=46925:1a234210f142/GNU-Fedora-x86_64-propcheck-assert/monetdb5/mTests/optimizer%2Fifthencst

In case these are acceptable / expected / intended / desired changes, the new output should be approved accordingly.
Otherwise, the respective code should be fixed.

Comment 19004

Date: 2013-08-16 07:57:38 +0200
From: MonetDB Mercurial Repository <>

Changeset ee10d1630870 made by Martin Kersten mk@cwi.nl in the MonetDB repo, refers to this bug.

For complete details, see http//devmonetdborg/hg/MonetDB?cmd=changeset;node=ee10d1630870

Changeset description:

Look for constants after evaluation
This should fix bug #3255

Comment 19005

Date: 2013-08-16 07:59:49 +0200
From: @mlkersten

should be done with

Comment 19006

Date: 2013-08-16 08:51:50 +0200
From: @drstmane

These tests did & do fail in the Feb2013 branch, only,
but did and do not fail in the default branch.

Comment 19007

Date: 2013-08-16 13:26:25 +0200
From: @drstmane

In the Feb2013 branch, these test, and this this bug appear to be fixed by changeset 62ed11377998 (i.e., not changeset ee10d1630870).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant