Various memory leaks in SQL compilation

[monetdb-team]

Date: 2014-04-14 16:07:40 +0200
From: Richard Hughes <<richard.monetdb>>
To: SQL devs <>
Version: 11.17.13 (Jan2014-SP1)
CC: @njnes

Last updated: 2014-05-22 09:52:24 +0200

Comment 19750

Date: 2014-04-14 16:07:40 +0200
From: Richard Hughes <<richard.monetdb>>

Created attachment 280
Stack traces of leak paths

I ran mserver5 under libtcmalloc's leak checker and produced the attached output. I was throwing arbitrary read-only queries at it from our front-end and I'm afraid I wasn't keeping track of the complete list; that was stupid of me. I do know that they were all of the form "select ... from (select ... from src where ...) as t(a,b,...) group by ..."

I eyeballed the stack traces and came up with the patch I'm going to attach shortly. Please re-do my analysis - I really have no idea what I'm doing.

Attached file: mserver5.15319.main-end.dot (application/msword, 7666 bytes)
Description: Stack traces of leak paths

Comment 19751

Date: 2014-04-14 16:08:30 +0200
From: Richard Hughes <<richard.monetdb>>

Created attachment 281
Proposed patch

Attached file: monetdb-sql-memory-leaks.diff (text/plain, 1946 bytes)
Description: Proposed patch

Comment 19753

Date: 2014-04-14 22:19:59 +0200
From: @njnes

thanks for the patch. I just applied it to the jan2014 branch.

Comment 19758

Date: 2014-04-17 23:46:57 +0200
From: Richard Hughes <<richard.monetdb>>

I feel disgustingly ungrateful questioning you like this, but did something go wrong with the merge? I can't see it in hg, either on default or Jan2014.

http://dev.monetdb.org/hg/MonetDB/log/tip/sql/backends/monet5/sql_gencode.c

Comment 19759

Date: 2014-04-18 10:04:23 +0200
From: @njnes

Your so right, I seem to have missed a hg push. Now its there (on
Jan2014).