Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace "exit" by "throw new Exception" #3933

Closed
monetdb-team opened this issue Nov 30, 2020 · 0 comments
Closed

replace "exit" by "throw new Exception" #3933

monetdb-team opened this issue Nov 30, 2020 · 0 comments

Comments

@monetdb-team
Copy link

@monetdb-team monetdb-team commented Nov 30, 2020

Date: 2016-02-25 13:00:05 +0100
From: Pierre Coustillas <>
To: clients devs <>
Version: 11.21.13 (Jul2015-SP2)

Last updated: 2016-03-25 09:59:22 +0100

Comment 21823

Date: 2016-02-25 13:00:05 +0100
From: Pierre Coustillas <>

"Exit" is bad for the calling script is stopped without notification

Patch :

diff /usr/share/php/monetdb/php_mapi.inc php_mapi.inc
311c311
< exit();

            throw new Exception($last_error . '. Check monetdb is started.');

420c420
< exit();

        throw new Exception($last_error . '. Monetdb was to stop since the last connection.');

434c434
< exit();

            throw new Exception($last_error . '. Monetdb was to stop during the execution of a query.');

443c443
< exit();

                throw new Exception($last_error . '. Monetdb was to stop during the execution of a query.');

Comment 21829

Date: 2016-02-26 15:15:48 +0100
From: MonetDB Mercurial Repository <>

Changeset 517d097f1eda made by Sjoerd Mullender sjoerd@acm.org in the MonetDB repo, refers to this bug.

For complete details, see http//devmonetdborg/hg/MonetDB?cmd=changeset;node=517d097f1eda

Changeset description:

Convert calls to exit to throwing exceptions.
This fixes bug #3933.

Comment 21830

Date: 2016-02-26 15:16:20 +0100
From: @sjoerdmullender

Exit is gone.

Comment 21963

Date: 2016-03-25 09:59:22 +0100
From: @sjoerdmullender

Jul2015-SP3 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant