Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message about incompatible BBP version should be clearer #6068

Closed
monetdb-team opened this issue Nov 30, 2020 · 0 comments
Closed

Error message about incompatible BBP version should be clearer #6068

monetdb-team opened this issue Nov 30, 2020 · 0 comments

Comments

@monetdb-team
Copy link

@monetdb-team monetdb-team commented Nov 30, 2020

Date: 2016-10-05 13:38:50 +0200
From: @eyalroz
To: Merovingian devs <>
Version: 11.23.7 (Jun2016-SP1)

Last updated: 2016-12-21 13:07:58 +0100

Comment 24457

Date: 2016-10-05 13:38:50 +0200
From: @eyalroz

User-Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:49.0) Gecko/20100101 Firefox/49.0
Build Identifier:

I suggest the following:

diff -r 6dfd8ffb7ab2 gdk/gdk_bbp.c
--- a/gdk/gdk_bbp.c Wed Oct 05 12:38:10 2016 +0200
+++ b/gdk/gdk_bbp.c Wed Oct 05 13:37:01 2016 +0200
@@ -1210,7 +1210,10 @@
bbpversion != GDKLIBRARY_OLDWKB &&
bbpversion != GDKLIBRARY_INSERTED &&
bbpversion != GDKLIBRARY_HEADED) {

  •           GDKfatal("BBPinit: incompatible BBP version: expected 0%o, got 0%o.", GDKLIBRARY, bbpversion);
    
  •           GDKfatal("BBPinit: incompatible BBP version: expected 0%o, got 0%o. "
    
  •                   "Database was likely created by a newer release or a development "
    
  •                   "version of the server, using an incompatible storage format." ,
    
  •                   GDKLIBRARY, bbpversion);
      }
      if (fgets(buf, sizeof(buf), fp) == NULL) {
              GDKfatal("BBPinit: short BBP");
    

or an alternative wording of the error message which would be clear to people who do not know what the BBP version means.

Reproducible: Always

Comment 24531

Date: 2016-10-18 11:47:12 +0200
From: MonetDB Mercurial Repository <>

Changeset 88921c8c1d79 made by Sjoerd Mullender sjoerd@acm.org in the MonetDB repo, refers to this bug.

For complete details, see http//devmonetdborg/hg/MonetDB?cmd=changeset;node=88921c8c1d79

Changeset description:

Elaborated error message for incompatible database version.
This fixes bug #6068.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant