Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daemon crashes if .merovignian_properties for a database contains more than 42 entries #6318

Closed
monetdb-team opened this issue Nov 30, 2020 · 0 comments

Comments

@monetdb-team
Copy link

@monetdb-team monetdb-team commented Nov 30, 2020

Date: 2017-05-16 09:58:31 +0200
From: @kutsurak
To: Merovingian devs <>
Version: 11.25.21 (Dec2016-SP4)

Last updated: 2017-06-12 15:14:47 +0200

Comment 25331

Date: 2017-05-16 09:58:31 +0200
From: @kutsurak

User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0
Build Identifier:

When attempting to start a database that has more than 42 properties in the .merovignian_properties file, the daemon crashes.

Reproducible: Always

Steps to Reproduce:

Assuming bash:

  1. monetdbd create /tmp/dbfarm
  2. monetdbd start /tmp/dbfarm
  3. monetdb create db
  4. for i in {1..42}; do monetdb set prop$i=val$i foo; done
  5. monetdb start db

Actual Results:

starting database 'db'... FAILED
start: incomplete response from monetdbd

(monetdbd has actually crashed)

Expected Results:

The database should start

Comment 25336

Date: 2017-05-16 11:17:56 +0200
From: MonetDB Mercurial Repository <>

Changeset 8cb80fc92ece made by Panagiotis Koutsourakis kutsurak@monetdbsolutions.com in the MonetDB repo, refers to this bug.

For complete details, see http//devmonetdborg/hg/MonetDB?cmd=changeset;node=8cb80fc92ece

Changeset description:

Make sure we don't touch memory that doesn't belong to us

The list argument of the function readConfFileFull has been allocated
statically, and now has length of 64. The convention in the existing code is
that the last entry is a sentinel, so in total we can use 63 entries. Make sure
we don't write past the last entry.

This fixes bug #6318
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant