Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused SQL global variable "history" #6475

Closed
monetdb-team opened this issue Nov 30, 2020 · 0 comments
Closed

Remove unused SQL global variable "history" #6475

monetdb-team opened this issue Nov 30, 2020 · 0 comments

Comments

@monetdb-team
Copy link

@monetdb-team monetdb-team commented Nov 30, 2020

Date: 2017-11-24 11:50:03 +0100
From: @yzchang
To: SQL devs <>
Version: -- development
CC: @yzchang

Last updated: 2019-04-30 12:36:03 +0200

Comment 25906

Date: 2017-11-24 11:50:03 +0100
From: @yzchang

User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_1) AppleWebKit/604.3.5 (KHTML, like Gecko) Version/11.0.1 Safari/604.3.5
Build Identifier:

MonetDB has a global variable called "history":

$ mclient
...
sql>select history;
+-------+
| L2 |
+=======+
| false |
+-------+
1 tuple (11.354ms)
sql>set history = true;
operation successful (11.904ms)
sql>select history;
+-------+
| L2 |
+=======+
| true |
+-------+
1 tuple (11.616ms)

But it seems to be unused. Probably it's a left over of the earlier query log implementation. If that's indeed the case, it should be removed.

Reproducible: Always

Comment 26811

Date: 2019-01-18 18:45:14 +0100
From: MonetDB Mercurial Repository <>

Changeset 9da76d750a37 made by Sjoerd Mullender sjoerd@acm.org in the MonetDB repo, refers to this bug.

For complete details, see https//devmonetdborg/hg/MonetDB?cmd=changeset;node=9da76d750a37

Changeset description:

Removed unused global SQL variable "history".
This fixes bug #6475.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant