Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when trying to replace a function defined in sys from a different schema #6499

Closed
monetdb-team opened this issue Nov 30, 2020 · 0 comments
Closed

Comments

@monetdb-team
Copy link

@monetdb-team monetdb-team commented Nov 30, 2020

Date: 2017-12-15 16:26:28 +0100
From: @swingbit
To: SQL devs <>
Version: 11.27.11 (Jul2017-SP3)
CC: @njnes

Last updated: 2018-02-12 16:12:15 +0100

Comment 26012

Date: 2017-12-15 16:26:28 +0100
From: @swingbit

User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.62 Safari/537.36
Build Identifier:

From a schema "spinque":

sql>select * from sys.functions where name='levenshtein';
+------+-------------+-------------+--------+----------+------+-------------+--------+--------+-----------+
| id | name | func | mod | language | type | side_effect | varres | vararg | schema_id |
+======+=============+=============+========+==========+======+=============+========+========+===========+
| 1273 | levenshtein | levenshtein | txtsim | 0 | 1 | false | false | false | 2000 |
| 1274 | levenshtein | levenshtein | txtsim | 0 | 1 | false | false | false | 2000 |
| 1327 | levenshtein | levenshtein | txtsim | 0 | 1 | false | false | false | 2000 |
| 1328 | levenshtein | levenshtein | txtsim | 0 | 1 | false | false | false | 2000 |
| 1381 | levenshtein | levenshtein | txtsim | 0 | 1 | false | false | false | 2000 |
| 1382 | levenshtein | levenshtein | txtsim | 0 | 1 | false | false | false | 2000 |
+------+-------------+-------------+--------+----------+------+-------------+--------+--------+-----------+
6 tuples (2.607ms)

sql>CREATE OR REPLACE FUNCTION levenshtein(s1 string, s2 string) RETURNS integer EXTERNAL NAME spinque."levenshtein_utf8";

This only occurs when the new function is replacing one in schema sys, not when replacing one in the same schema.

Reproducible: Always

$ mserver5 --version
MonetDB 5 server v11.27.12 (64-bit, 128-bit integers)
This is an unreleased version
Copyright (c) 1993-July 2008 CWI
Copyright (c) August 2008-2017 MonetDB B.V., all rights reserved
Visit https://www.monetdb.org/ for further information
Found 15.6GiB available memory, 8 available cpu cores
Libraries:
libpcre: 8.41 2017-07-05 (compiled with 8.41)
openssl: OpenSSL 1.1.0g 2 Nov 2017 (compiled with OpenSSL 1.1.0g-fips 2 Nov 2017)
libxml2: 2.9.4 (compiled with 2.9.4)
Compiled by: roberto@photon.hq.spinque.com (x86_64-unknown-linux-gnu)
Compilation: gcc -O3 -fomit-frame-pointer -pipe -Werror -Wall -Wextra -W -Werror-implicit-function-declaration -Wpointer-arith -Wdeclaration-after-statement -Wundef -Wformat=2 -Wno-format-nonliteral -Winit-self -Winvalid-pch -Wmissing-declarations -Wmissing-format-attribute -Wmissing-prototypes -Wold-style-definition -Wpacked -Wunknown-pragmas -Wvariadic-macros -fstack-protector-all -Wstack-protector -Wpacked-bitfield-compat -Wsync-nand -Wjump-misses-init -Wmissing-include-dirs -Wlogical-op -Wduplicated-cond -Wduplicated-branches -Wrestrict -Wnested-externs -Wunreachable-code -D_FORTIFY_SOURCE=2
Linking : /usr/bin/ld -m elf_x86_64

Comment 26024

Date: 2017-12-17 11:30:39 +0100
From: @njnes

the problem is indeed related to the schema (as these functions do not have a schema). For now we cannot allow dropping/replacing these functions.

Comment 26025

Date: 2017-12-17 12:29:49 +0100
From: MonetDB Mercurial Repository <>

Changeset c47c58f29320 made by Niels Nes niels@cwi.nl in the MonetDB repo, refers to this bug.

For complete details, see https//devmonetdborg/hg/MonetDB?cmd=changeset;node=c47c58f29320

Changeset description:

corrected fix for bug #6499, ie only disallow system functions (not all)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant