Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mar2018]: mclient reports incorrect wall-clock time #6541

Closed
monetdb-team opened this issue Nov 30, 2020 · 0 comments
Closed

[Mar2018]: mclient reports incorrect wall-clock time #6541

monetdb-team opened this issue Nov 30, 2020 · 0 comments

Comments

@monetdb-team
Copy link

@monetdb-team monetdb-team commented Nov 30, 2020

Date: 2018-02-13 15:49:49 +0100
From: @drstmane
To: clients devs <>
Version: 11.27.13 (Jul2017-SP4)

Last updated: 2018-03-29 15:39:12 +0200

Comment 26190

Date: 2018-02-13 15:49:49 +0100
From: @drstmane

$ echo -e ' select 0; \n select avg(value) from sys.generate_series(0,1000000000); \n select 0; '
select 0;
select avg(value) from sys.generate_series(0,1000000000);
select 0;

$ echo -e ' select 0; \n select avg(value) from sys.generate_series(0,1000000000); \n select 0; ' | mclient
+------+
| L2 |
+======+
| 0 |
+------+
1 tuple
clk: 5.00 sec
+--------------------------+
| L6 |
+==========================+
| 499999999.5 |
+--------------------------+
1 tuple
clk: 5.00 sec
+------+
| L2 |
+======+
| 0 |
+------+
1 tuple
clk: 5.00 sec

Comment 26191

Date: 2018-02-13 16:05:41 +0100
From: @drstmane

The problem is the very problem that was the reason with mclient reported (per query) timing only in "interactve" (or "echo") mode, i.e., only when mclient sends individual queries (or at least lines) to the server, and thus indeed measures the wall-clock time for individual queries, rather than sending the entire input / file, and this measuring the wall-clock time for the entire batch.

Without "--interative" or "--echo", mclient now reports per query the time it took to execute the entire batch of queries sent to the server.

To ensure that the mclient indeed report the wall-clock time for what it actually measures, mclient should
(1) either send individual queries to the server (much like "--interactive", which enabled interpretation of ''-commands, and "--echo", which echos each query sent to the server) when the timermode is other than none,
(2) or report wall-clock time (only) for what is indeed measure, i.e., at the end of an entire batch of queries sent to the server in "batch-mode"; and per query only if mclient indeed sends individual queries to the server, e.g., when --interactive or --echo are used.

Comment 26192

Date: 2018-02-14 09:56:31 +0100
From: MonetDB Mercurial Repository <>

Changeset 9e804389aee9 made by Stefan Manegold Stefan.Manegold@cwi.nl in the MonetDB repo, refers to this bug.

For complete details, see https//devmonetdborg/hg/MonetDB?cmd=changeset;node=9e804389aee9

Changeset description:

mclient: report only the wall-clock times we do indeed measure:
when mclient sends individual queries (lines) to the server
in interactive mode, report wall-clock per query;
otherwise, report (only) total wall-clock for the entire
batch sent, executed, and measured.


This should fix bug #6541.

Comment 26195

Date: 2018-02-14 10:15:08 +0100
From: @drstmane

Fixed by changeset 9e804389aee9 .

Comment 26307

Date: 2018-03-29 15:39:12 +0200
From: @sjoerdmullender

The Mar2018 version has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant