Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in mclient a strang msg is reported after issueing command: set schema sys; #6754

Closed
monetdb-team opened this issue Nov 30, 2020 · 0 comments
Closed

Comments

@monetdb-team
Copy link

@monetdb-team monetdb-team commented Nov 30, 2020

Date: 2019-09-05 18:58:28 +0200
From: Martin van Dinther <<martin.van.dinther>>
To: clients devs <>
Version: 11.33.11 (Apr2019-SP1)
CC: @PedroTadim

Last updated: 2020-01-02 16:51:45 +0100

Comment 27263

Date: 2019-09-05 18:58:28 +0200
From: Martin van Dinther <<martin.van.dinther>>

User-Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:67.0) Gecko/20100101 Firefox/67.0
Build Identifier:

In mclient a message
"auto commit mode: on"
is reported when issueing a "set schema sys;" command on the command line.
As setting/changing the current working schema is not changing the transaction state, I do not understand why it is reported to the user!
I would expected a normal message
"operation successful"
to be reported as is done when issueing other set commands.

Reproducible: Always

Steps to Reproduce:

  1. start mserver5
  2. start mclient
  3. enter commands:
    set schema sys;
    set schema json;
    set role monetdb;
    declare a int;
    set a = 4;
    set schema sys;

Actual Results:

sql>set schema sys;
auto commit mode: on
sql>set schema json;
auto commit mode: on
sql>set role monetdb;
operation successful
sql>declare a int;
operation successful
sql>set a = 4;
operation successful
sql>set schema sys;
auto commit mode: on
sql>

Expected Results:

sql>set schema sys;
operation successful
sql>set schema json;
operation successful
sql>set role monetdb;
operation successful
sql>declare a int;
operation successful
sql>set a = 4;
operation successful
sql>set schema sys;
auto commit mode: on
sql>

Analysing mclient.c lines 1932..1937 where the message is printed, it appears the server has classified the "set schema sys;" command as Q_TRANS (mapi_get_querytype(hdl) == Q_TRANS). That is probably incorrectly set by the server.

In jdbcclient the message "Connection warning: Server enabled auto commit mode while local state already was auto commit." is reported.

Comment 27264

Date: 2019-09-05 19:17:12 +0200
From: MonetDB Mercurial Repository <>

Changeset 7a0d8d038d0f made by Sjoerd Mullender sjoerd@acm.org in the MonetDB repo, refers to this bug.

For complete details, see https//devmonetdborg/hg/MonetDB?cmd=changeset;node=7a0d8d038d0f

Changeset description:

Change message printed by mclient.
This fixes bug #6754.

Comment 27502

Date: 2020-01-02 16:51:45 +0100
From: MonetDB Mercurial Repository <>

Changeset e1b1297f0222 made by Martin van Dinther martin.van.dinther@monetdbsolutions.com in the MonetDB repo, refers to this bug.

For complete details, see https//devmonetdborg/hg/MonetDB?cmd=changeset;node=e1b1297f0222

Changeset description:

Add test for bug #6754
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant