Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProfilerStart is not threadsafe #6769

Closed
monetdb-team opened this issue Nov 30, 2020 · 0 comments
Closed

ProfilerStart is not threadsafe #6769

monetdb-team opened this issue Nov 30, 2020 · 0 comments

Comments

@monetdb-team
Copy link

@monetdb-team monetdb-team commented Nov 30, 2020

Date: 2019-10-06 09:49:08 +0200
From: @mlkersten
To: MonetDB5 devs <>
Version: 11.33.11 (Apr2019-SP1)

Last updated: 2019-11-28 10:00:03 +0100

Comment 27338

Date: 2019-10-06 09:49:08 +0200
From: @mlkersten

User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:69.0) Gecko/20100101 Firefox/69.0
Build Identifier:

The idea behind the stethoscope is to hook it up at any time to inspect what is going on in the server. For this we keep the instructions being executed in the client record. When the stethoscope starts, it inspects all client records and issues START events of those already in progress,
However, the underlying data structure clients->inprogress is not protected against updates. This may lead to invalid pointers while preparing the profiler event string.

Reproducible: Always

Comment 27339

Date: 2019-10-06 14:23:07 +0200
From: @mlkersten

Added explicit locks around the global variable to fix it at the cost of few calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant