Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Windows Messages translation for errno error codes. #6779

Closed
monetdb-team opened this issue Nov 30, 2020 · 0 comments
Closed

Using Windows Messages translation for errno error codes. #6779

monetdb-team opened this issue Nov 30, 2020 · 0 comments

Comments

@monetdb-team
Copy link

@monetdb-team monetdb-team commented Nov 30, 2020

Date: 2019-10-23 08:20:27 +0200
From: daniel.zvinca
To: GDK devs <>
Version: 11.33.3 (Apr2019)

Last updated: 2019-11-28 10:00:03 +0100

Comment 27378

Date: 2019-10-23 08:20:27 +0200
From: daniel.zvinca

User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.120 Safari/537.36
Build Identifier:

During a complex join between two tables that involve an OR operation, I received the following error message:

!OS: The printer is out of paper.

This corresponds to error number 28 in Windows OS, yet in errno.h, 28 is for ENOSPC, which is the expected one.

Reproducible: Always

Steps to Reproduce:

My quick fix was to return the error code unchanged in winerror function (mutils.c). But I can't be sure that this doesn't mess up with some other cases.

Comment 27385

Date: 2019-10-31 13:29:40 +0100
From: MonetDB Mercurial Repository <>

Changeset b3190f961601 made by Sjoerd Mullender sjoerd@acm.org in the MonetDB repo, refers to this bug.

For complete details, see https//devmonetdborg/hg/MonetDB?cmd=changeset;node=b3190f961601

Changeset description:

Try not to confuse Windows and Unix error numbers.
Use GDKsyserror exclusively for errno-based errors, and introduce
GDKwinerror for errors obtained with GetLastError().
This should fix bug #6779.

Comment 27386

Date: 2019-10-31 13:31:14 +0100
From: @sjoerdmullender

Should be fixed now for the upcoming release. If not, please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant