Fix test_modelselectfield_multiple #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@lafrech this should make the build green again. Let me know if it looks good! |
Member
Author
|
The only remaining failing tests are related to pallets/flask#1841 and will be fixed once Flask v0.11.2 is released. |
Member
|
Thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #269
Closes #271
This test was invalid all along, because:
dogs, but that field hadallow_blank == False.dogsby submitting an empty list, while in reality clearing happens by submitting a "__None" string. I built a test Flask app and verified this is how it works.pallets/werkzeug#991 was only a side effect that exposed this invalid test.