Skip to content

Conversation

@yalon
Copy link
Contributor

@yalon yalon commented Jun 22, 2018

Fix issues #1286 and #844 (basically the same issue).

…y set from filters that reference the same field several times, do not assume each value is a dict
@yalon
Copy link
Contributor Author

yalon commented Jun 22, 2018

Since the specific failure that happened on Python 3.6 didn't happen when I ran that test (test_no_cached_queryset) on my machine, and Travis shows that this passes for Python 3.5/2.7 with the same Mongo settings I suspect the issue is not with the PR itself but hidden dependencies/missing cleanups between tests.

@bagerard
Copy link
Collaborator

bagerard commented Sep 3, 2018

@yalon The CI failed for reasons not related to your PR. Could you pull master in your branch and push again? that way the CI will run again . Thanks!

@erdenezul
Copy link
Collaborator

@bagerard you can do the same things that you mentioned still @yalon get's credit for his PR.

@bagerard
Copy link
Collaborator

bagerard commented Sep 3, 2018

OK will do, I thought I would let a chance to the author before doing that but I'll push another PR :)
The test that failed in the CI is actually failing from time to time, I'll try to investigate what could be wrong in there

@yalon
Copy link
Contributor Author

yalon commented Sep 3, 2018

Thanks - I don't mind the credit, just happy we worked this out :)

@erdenezul erdenezul merged commit 080226d into MongoEngine:master Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants