Skip to content

Conversation

@wojcikstefan
Copy link
Member

  1. We were unnecessarily creating a changed_fields variable, assigning [] to it.
  2. We were not modifying it at all.
  3. In the end, we were setting obj._changed_fields to that variable instead of [] directly.

There's still more work to be done to make handling of _changed_fields simple and intuitive (see the TODO in the code), but this minor tweak will do for now.

@wojcikstefan wojcikstefan merged commit 09c7797 into master Jun 17, 2019
@wojcikstefan wojcikstefan deleted the changed-fields-in-from-son-cleanup branch June 17, 2019 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants