Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mongoengine/base/document.py
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ def __setattr__(self, name, value):
# Handle dynamic data only if an initialised dynamic document
if self._dynamic and not self._dynamic_lock:

if not hasattr(self, name) and not name.startswith("_"):
if name not in self._fields_ordered and not name.startswith("_"):
DynamicField = _import_class("DynamicField")
field = DynamicField(db_field=name, null=True)
field.name = name
Expand Down
22 changes: 22 additions & 0 deletions tests/fields/test_sequence_field.py
Original file line number Diff line number Diff line change
Expand Up @@ -274,3 +274,25 @@ class Bar(Base):
assert foo.counter == bar.counter
assert foo._fields["counter"].owner_document == Foo
assert bar._fields["counter"].owner_document == Bar

def test_sequence_setattr_not_incrementing_counter(self):
class Person(DynamicDocument):
id = SequenceField(primary_key=True)
name = StringField()

self.db["mongoengine.counters"].drop()
Person.drop_collection()

for x in range(10):
Person(name="Person %s" % x).save()

c = self.db["mongoengine.counters"].find_one({"_id": "person.id"})
assert c["next"] == 10

# Setting SequenceField field value should not increment counter:
new_person = Person()
new_person.id = 1100

# Counter should still be at 10
c = self.db["mongoengine.counters"].find_one({"_id": "person.id"})
assert c["next"] == 10