New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support for Custom Music #1592

Merged
merged 2 commits into from May 15, 2018

Conversation

Projects
None yet
4 participants
@ThePotatoGuy
Member

ThePotatoGuy commented May 14, 2018

#1370 #1143 #795 #573 #542 #511 #309

Surprise~

We did something.

Now everyone can stop asking about this.

How to add music:

  1. The music you want to add must be OGG format. Not just an .ogg extension. If it crashes because you renamed an .mp3 to an .ogg , that's not our problem.
  2. Create a new directory custom_bgm in your DDLC/ directory.
  3. Drop the oggs into that directory.
  4. Launch game.

Technical

  • Files are checked for access as well as extension. Appropriate files are added to music_choices in the initMusicChoices function.
  • I've also added some checking in init to clear persistent.current_track if its filepath does not resolve to an actual file. This will prevent crashes if the last played music track is removed prior to next launch.
@Tiler17

This comment has been minimized.

Contributor

Tiler17 commented May 14, 2018

Will you continue to add default music? I think this is neat and all, but I still adore 80s Doki Doki, and I never would've come across that otherwise. Or the most recent track that was added

@ThePotatoGuy

This comment has been minimized.

Member

ThePotatoGuy commented May 14, 2018

Yes, we'll continue to add music that works with MAS.

@kaido1224

This comment has been minimized.

Contributor

kaido1224 commented May 15, 2018

Great idea. Tater you are a genius.

@ThePotatoGuy ThePotatoGuy merged commit efe62ba into Monika-After-Story:enhancement May 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment