Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SpriteEffect half pixel offset #4939

Closed
tomspilman opened this issue Jun 15, 2016 · 2 comments
Closed

Fix SpriteEffect half pixel offset #4939

tomspilman opened this issue Jun 15, 2016 · 2 comments

Comments

@tomspilman
Copy link
Member

Now that we've made SpriteEffect public we have to make sure it works.

Currently you can see it is always applying a half pixel offset... even on platforms that don't require it:

https://github.com/mono/MonoGame/blob/develop/MonoGame.Framework/Graphics/Effect/SpriteEffect.cs#L62

It should use the SpriteBatch.NeedsHalfPixelOffset flag like SpriteBatch does:
https://github.com/mono/MonoGame/blob/develop/MonoGame.Framework/Graphics/SpriteBatch.cs#L140

While we're at it we should add in a unit test for it since we need to ensure it works now.

@Verser
Copy link

Verser commented Nov 17, 2016

@tomspilman Just checking, this seems to be complete but is marked as Open and HelpWanted. Should this be closed?

@tomspilman
Copy link
Member Author

@Verser - Thanks... we just forgot to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants