We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Now that we've made SpriteEffect public we have to make sure it works.
SpriteEffect
Currently you can see it is always applying a half pixel offset... even on platforms that don't require it:
https://github.com/mono/MonoGame/blob/develop/MonoGame.Framework/Graphics/Effect/SpriteEffect.cs#L62
It should use the SpriteBatch.NeedsHalfPixelOffset flag like SpriteBatch does: https://github.com/mono/MonoGame/blob/develop/MonoGame.Framework/Graphics/SpriteBatch.cs#L140
SpriteBatch.NeedsHalfPixelOffset
SpriteBatch
While we're at it we should add in a unit test for it since we need to ensure it works now.
The text was updated successfully, but these errors were encountered:
Fix SpriteEffect half pixel offset MonoGame#4939
6faef81
@tomspilman Just checking, this seems to be complete but is marked as Open and HelpWanted. Should this be closed?
Sorry, something went wrong.
@Verser - Thanks... we just forgot to close this.
No branches or pull requests
Now that we've made
SpriteEffect
public we have to make sure it works.Currently you can see it is always applying a half pixel offset... even on platforms that don't require it:
https://github.com/mono/MonoGame/blob/develop/MonoGame.Framework/Graphics/Effect/SpriteEffect.cs#L62
It should use the
SpriteBatch.NeedsHalfPixelOffset
flag likeSpriteBatch
does:https://github.com/mono/MonoGame/blob/develop/MonoGame.Framework/Graphics/SpriteBatch.cs#L140
While we're at it we should add in a unit test for it since we need to ensure it works now.
The text was updated successfully, but these errors were encountered: