Fix MonoGame.Framework.dll.config to be named properly on MacOS and Linux #1147

Merged
merged 2 commits into from Jan 6, 2013

3 participants

@elisee

The output DLLs for MacOS and Linux were recently renamed to not include any suffix.

This commit updates the output names of the correspondig .dll.config files to match the new names.

This is required for MonoGame to work at all on Mac and Linux.

@tomspilman
MonoGame member

I cannot comment on this change myself... don't know Linux or Mac well.

But I did notice Linux and Mac are both still including "libmojoshader" which is no longer used. We should remove that from those vcprojs.

@elisee

I can remove all references to it in another pull request. Maybe you could open a separate issue just for that?

@KonajuGames

Those config files simply reference mojoshader and glsloptimizer. Probably better to remove them completely.

@elisee

Neither of them are useful anymore?

@KonajuGames

As Tom said, they're no longer used.

@elisee

Tom mentionned libmojoshader, but if glsloptimizer isn't useful either then I'll close this and submit another pull request removing the files.

@elisee elisee closed this Jan 6, 2013
@tomspilman
MonoGame member

We don't use either MonoShader or glslOptimizer at runtime anymore. Shaders are converted and optimized in the MGFX tools offline.

Also note for the future that you don't have to close this pull to add changes. You can simply commit more changes to your branch and they will automatically appear here.

@elisee

Yeah after pressing the button I started wondering whether it was better to keep the history here or make a new one. I'll reopen it with the new commit ASAP.

@elisee elisee reopened this Jan 6, 2013
@elisee

Ok should be good for pulling now.

@tomspilman
MonoGame member

Cool.... merging. Thanks for the fix!

@tomspilman tomspilman merged commit 14c3585 into MonoGame:develop3d Jan 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment