Use IWindowInfo.Handle to retrieve window handle #2166

Closed
wants to merge 12 commits into
from

Conversation

Projects
None yet
7 participants
@thefiddler
Contributor

thefiddler commented Dec 16, 2013

OpenTK 1.1 offers a public GameWindow.WindowInfo.Handle property. This patch removes reflection from the startup path in favor of accessing the Handle property directly.

This patch depends on https://github.com/kungfubanana/MonoGame-Dependencies/pull/43

Use IWindowInfo.Handle to retrieve window handle
OpenTK 1.1 offers a public GameWindow.WindowInfo.Handle property. This
patch removes reflection from the startup path in favor of accessing the
Handle property directly.
@mgbot

This comment has been minimized.

Show comment
Hide comment
@mgbot

mgbot Dec 16, 2013

Member

Can one of the admins verify this patch?

Member

mgbot commented Dec 16, 2013

Can one of the admins verify this patch?

@mgbot

This comment has been minimized.

Show comment
Hide comment
@mgbot

mgbot Dec 16, 2013

Member

Can one of the admins verify this patch?

Member

mgbot commented Dec 16, 2013

Can one of the admins verify this patch?

@tomspilman

This comment has been minimized.

Show comment
Hide comment
@tomspilman

tomspilman Dec 16, 2013

Member

@mgbot test

Member

tomspilman commented Dec 16, 2013

@mgbot test

@mgbot

This comment has been minimized.

Show comment
Hide comment
@mgbot

mgbot Dec 16, 2013

Member

Test FAILed.
Refer to this link for build results: http://build.monogame.net/job/PullRequestTester/528/

Member

mgbot commented Dec 16, 2013

Test FAILed.
Refer to this link for build results: http://build.monogame.net/job/PullRequestTester/528/

@thefiddler

This comment has been minimized.

Show comment
Hide comment
@thefiddler

thefiddler Dec 16, 2013

Contributor
@tomspilman

This comment has been minimized.

Show comment
Hide comment
@tomspilman

tomspilman Dec 16, 2013

Member

Sorry... totally missed that.

Member

tomspilman commented Dec 16, 2013

Sorry... totally missed that.

PumpkinPaul and others added some commits Sep 23, 2013

Some fixes to PSM rendering
Added TexCoord to BasicEffect shaders
Removed default BlendState for BasicEffect pass
Renamed reserved word Texture effect parameter in BasicEffect
Look for EXACT vertex buffer match (vertex and index array sizes must match request)
Change clear colour for Intel performance.
THIS BREAKS XNA COMPATIBILITY!

Modern (Sandybridge +) Intel Integrated Graphics chipsets have
a fast clear/blit unit ('blorp') which, at least under Mesa,
can only do fast color clears if all of the channels are being cleared
to either full (1.0 or 255) or empty (0). The default XNA discard
colour, CornflowerBlue, does not have this property. This patch
changes the discard colour to black (0,0,0,255) as this is the colour
likely to be best supported by hardware.

This patch gets rid of a per-clear warning on Intel Ivybride/Mesa 10.0 git
using ARB_debug_output.
Updated NuGet packages for 3rd December 2013
New NuGet packages published from code version as of this date

Only known issue, Win GL project still referencing SharpDX Raw Input

NuGet releases now 3.1.1-Alpha
Repackaged 3rd December release. Odd dll issue for Store builds.
*Note found an 8.1 bug which needs resolving with the package.
Will also refresh for a more recent release with this fix
Updated for December 10 cut.
Resolved Windows 8 build issue
Windows 8.1 package updated to be fully functional
@thefiddler

This comment has been minimized.

Show comment
Hide comment
@thefiddler

thefiddler Jan 4, 2014

Contributor

Messed up remote tracking, need to rtfm git.

Contributor

thefiddler commented Jan 4, 2014

Messed up remote tracking, need to rtfm git.

@thefiddler thefiddler closed this Jan 4, 2014

@thefiddler thefiddler deleted the thefiddler:noreflect branch Jan 4, 2014

@thefiddler thefiddler restored the thefiddler:noreflect branch Jan 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment