Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bug 2079 - Implemented SetVibration for Windows8 as a method stub for co... #2187

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
5 participants
Contributor

joncloud commented Jan 8, 2014

...mpilation compatibility, and with VibrateController for WindowsPhone.

Bug 2079 - Implemented SetVibration for Windows8 as a method stub for…
… compilation compatibility, and with VibrateController for WindowsPhone.
Owner

tomspilman commented Jan 8, 2014

We actually have decided to not include stubs in MonoGame moving forward. If a feature is unimplemented we ideally want it to be apparent to the user at compile time.

In this case if you want to leave the stub in, but commented out.... that would be acceptable. It leaves a hint that it needs to be written, but doesn't trick the user into thinking their game is fully working.

Member

mgbot commented Jan 8, 2014

Can one of the admins verify this patch?

Member

mgbot commented Jan 8, 2014

Can one of the admins verify this patch?

Contributor

joncloud commented Jan 8, 2014

That makes sense. Would you prefer to have it commented in? Also what do you think of the implementation with VibrateController?

Owner

tomspilman commented Jan 8, 2014

Would you prefer to have it commented in?

Yea... just put a block comment around it. Maybe add a "TODO: Implement Me" or something.

Also what do you think of the implementation with VibrateController?

Not sure.

My first inclination is to not support GamePad.SetVibration on a phone. You would probably design vibration on a phone differently from that of a gamepad. That would mean separate code paths in your game and hence a different API all together.

@KonajuGames @dellis1972 ?

Contributor

KonajuGames commented Jan 8, 2014

Games on Windows Phone 7 use VibrateController directly as GamePad does
nothing on that platform (except for handling the Back button). We should
do the same, especially now that there are gamepad controllers that work
with Windows Phone 8 such as MOGA. I have been entertaining the thought of
adding support for the MOGA controllers for iOS, Android and Windows Phone
8.​

Bug 2079 - Removed the implementation of GamePad.SetVibration, and wr…
…apped the original implementation with a TODO Comment.
Contributor

danzel commented Apr 20, 2014

This PR is obsolete as of #2369 being merged. Please close.

@joncloud joncloud closed this Apr 20, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment