New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic HalfVector2.cs, fixed Android build errors. #392

Merged
merged 10 commits into from Mar 25, 2012

Conversation

Projects
None yet
2 participants
@bonesoul
Copy link
Contributor

bonesoul commented Mar 23, 2012

  • I have added very basic HalfVector2.cs implementation based on XNA implementation.
  • Also added HalfVector2 support to GraphicsExtensions.cs:OpenGLVertexAttribPointerType().
  • Fixed android project build errors.

bonesoul added some commits Mar 23, 2012

Removed HalfUtils.cs as HalfTypeHelper.cs was already there which I m…
…issed at first hand.

Converted HalfVector2.cs so that it uses HalfTypeHelper.cs instead.
Added HalfVector2 support to GraphicsExtensions.cs:OpenGLVertexAttribPointerType().
@bonesoul

This comment has been minimized.

Copy link
Contributor

bonesoul commented Mar 23, 2012

@bonesoul

This comment has been minimized.

Copy link
Contributor

bonesoul commented Mar 23, 2012

@bonesoul

This comment has been minimized.

Copy link
Contributor

bonesoul commented Mar 23, 2012

Only android build errors out which is actually caused by develop3d branch itself: http://peanutcode.com/mgbuild/builds/71/

@bonesoul

This comment has been minimized.

Copy link
Contributor

bonesoul commented Mar 23, 2012

  • Very latest build logs after Linux & MacOS project files fixes: http://peanutcode.com/mgbuild/builds/73/.
  • Note that Linux & MacOS project files was already missing other packed-vector so files which I've added them also.
@bonesoul

This comment has been minimized.

Copy link
Contributor

bonesoul commented Mar 23, 2012

Okay android build errors are now also fixed: http://peanutcode.com/mgbuild/builds/75/ - all passed.

@bonesoul bonesoul closed this Mar 24, 2012

@bonesoul bonesoul reopened this Mar 24, 2012

@@ -154,7 +154,7 @@ public void Dispose()

public void ApplyChanges()
{
_game.Window.SetSupportedOrientations(_supportedOrientations);
_game.Window.SetSupportedOrientations(_supportedOrientations);

This comment has been minimized.

@espes

espes Mar 25, 2012

Contributor

Just fix this annoyance and it can be merged

@espes

View changes

MonoGame.Framework/GraphicsDeviceManager.cs Outdated
{
_game.Window.SetSupportedOrientations(_supportedOrientations);
{
_game.Window.SetSupportedOrientations(_supportedOrientations);

This comment has been minimized.

@espes

espes Mar 25, 2012

Contributor

like, these change lines being present when there wasn't any change. Breaks git blame :/

This comment has been minimized.

@bonesoul

bonesoul Mar 25, 2012

Contributor

actually there was a change there which I tried a fix (bonesoul@a9696b8 and bonesoul@f8274d6), though slygamer provided a correct fix later for it (#395).

So I decided to remove my changes back on that file which eventually broke the blame.

I'll be removing that annoyance now.

This comment has been minimized.

@bonesoul

bonesoul Mar 25, 2012

Contributor

It should be all okay now.

espes added a commit that referenced this pull request Mar 25, 2012

Merge pull request #392 from raistlinthewiz/develop3d
Added basic HalfVector2.cs, fixed Android build errors.

@espes espes merged commit ca8a947 into MonoGame:develop3d Mar 25, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment