Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Improvements to Pipeline Gtk implementation #4459

Merged
merged 1 commit into from Mar 31, 2016

Conversation

Projects
None yet
3 participants
@cra0zy
Copy link
Member

commented Jan 24, 2016

This PR fixes stuff mentioned in #4457 for Gtk Pipeline Tool.

Stuff done:

  • Added "Open With", Linux only
  • Added Undo/Redo toolbar buttons
  • Added Cancel toolbar button which appears while the build is running, and build/rebuild buttons hide
  • Updated reference dialog to mimic WinForms one
  • Updated how reference property is displayed in propertygrid
  • Made headerbar separator invisible in case build/rebuild/cancel build aren't visible
  • Allowed user scrolling of build output possible
  • Smoother scrolling
  • Fixed opening of files that contain spaces

Update no. 1:

  • Toolbar items / Headerbar items are now connected to actions, this means that changing something on action will change them as well
  • Headerbar now has a proper menu

Update no. 2:

  • Fixed pressing open and then canceling creating an empty base item
  • Separate "Exclude from Project" and "Delete" options
  • Made build output cursor invisible (not mouse cursor, text cursor, text can still be selected)

@cra0zy cra0zy force-pushed the cra0zy:paper branch from bb73eb0 to 1df2c8c Jan 24, 2016


dialog.AddButton("Delete", ResponseType.Apply);
dialog.AddButton("Cancel", ResponseType.Cancel);
dialog.AddButton("Remove", ResponseType.Ok);

This comment has been minimized.

Copy link
@tomspilman

tomspilman Jan 25, 2016

Member

The alternative implementation is having a separate Delete and Remove commands sort of like VS.

I do worry that mixing them both together like this... then having a 3 button prompt... could lead to costly mistakes by users.

A remove which works without prompts and a delete that asks a "Are you sure this is not undoable"... seems like a safer approach.

@dellis1972 @KonajuGames ?

This comment has been minimized.

Copy link
@cra0zy

cra0zy Jan 25, 2016

Author Member

MonoDevelop/Xamarin Studio has this type of delete dialog:

deletedilalog

@cra0zy

This comment has been minimized.

Copy link
Member Author

commented Jan 26, 2016

I am gonna use this PR to test something.

@cra0zy cra0zy force-pushed the cra0zy:paper branch 6 times, most recently from ff64f54 to 24b3d3b Jan 26, 2016

@cra0zy

This comment has been minimized.

Copy link
Member Author

commented Jan 27, 2016

I am done with testing. One of the things I tested was Gtk Pipeline on Windows, with Gtk 3 the window looks very good, but the menus in menubar are awful, and with Gtk 2 menubar and toolbar background colors are off, which isn't that hard to override.

Gtk on Windows is 32 bit only, so I wouldn't use it, this was more of a test to see how it looks.

@cra0zy cra0zy force-pushed the cra0zy:paper branch from 24b3d3b to f76adbf Feb 4, 2016

@cra0zy

This comment has been minimized.

Copy link
Member Author

commented Feb 4, 2016

@tomspilman I've done what you've asked.

@cra0zy cra0zy force-pushed the cra0zy:paper branch 3 times, most recently from 2dab20c to f0c9f21 Feb 4, 2016

@cra0zy

This comment has been minimized.

Copy link
Member Author

commented Feb 7, 2016

@dellis1972 @tomspilman Can this be merged so I can start working on WinForms side of things for #4457 ?

@cra0zy

This comment has been minimized.

Copy link
Member Author

commented Feb 10, 2016

Bummer :|

@tomspilman

This comment has been minimized.

Copy link
Member

commented Feb 10, 2016

Sorry... just been busy with work stuff. I'll get to it tonight for sure.

@cra0zy cra0zy force-pushed the cra0zy:paper branch from f0c9f21 to 75eebcd Feb 11, 2016

@cra0zy

This comment has been minimized.

Copy link
Member Author

commented Feb 11, 2016

I noticed that CollectionEditorDIalog.GUI.cs had tabs left, so I just replaced them with spaces.

@cra0zy cra0zy force-pushed the cra0zy:paper branch from 75eebcd to d538477 Feb 11, 2016

@cra0zy

This comment has been minimized.

Copy link
Member Author

commented Feb 21, 2016

Bummer :|

Agreed :P

@cra0zy cra0zy force-pushed the cra0zy:paper branch from d538477 to 3aa2d97 Feb 27, 2016

@cra0zy

This comment has been minimized.

Copy link
Member Author

commented Feb 27, 2016

I rebased this so it builds with the new build system.

@cra0zy

This comment has been minimized.

Copy link
Member Author

commented Mar 19, 2016

@tomspilman @KonajuGames @dellis1972 Can this be merged for 3.5.1? I am tired of recompiling it each time I want to update system MG...

@KonajuGames

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2016

Added it to the 3.5.1 milestone label so it doesn't get missed.

@cra0zy

This comment has been minimized.

Copy link
Member Author

commented Mar 20, 2016

Thanks

@tomspilman

This comment has been minimized.

Copy link
Member

commented Mar 21, 2016

I've moved this to 3.6... we will wrap up this 3.5 service release this week, but that shouldn't keep this from being merged.

@cra0zy

This comment has been minimized.

Copy link
Member Author

commented Mar 30, 2016

Since 3.5.1 got merged, can this get merged now? I really really really want to start working on what's discussed in #4238

@tomspilman

This comment has been minimized.

Copy link
Member

commented Mar 31, 2016

Thanks @cra0zy !

@tomspilman tomspilman merged commit 5c12802 into MonoGame:develop Mar 31, 2016

4 checks passed

Build Mac, iOS, and Linux Finished TeamCity Build MonoGame :: Build Mac : Running
Details
Build Windows, Web, Android, and OUYA Finished TeamCity Build MonoGame :: Build Windows : Running
Details
Package Mac and Linux Finished TeamCity Build MonoGame :: Package Mac and Linux : Running
Details
Package Windows SDK Finished TeamCity Build MonoGame :: Package Windows : Running
Details

@cra0zy cra0zy deleted the cra0zy:paper branch Mar 31, 2016

@tomspilman tomspilman changed the title [Gtk Pipeline] General Improvements #4457 General Improvements to Pipeline Gtk implementation Jun 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.