Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't swap PreferredBackBufferWidth/Height #5569

Closed

Conversation

@nkast
Copy link
Contributor

commented Mar 10, 2017

-also remove _backBufferScale

Fixes #5555

@tomspilman

This comment has been minimized.

Copy link
Member

commented Mar 10, 2017

Did you actually test the behavior of not having _backBufferScale?

I sort of remember when I wrote that code that I was trying to mimic the XNA WP7 behavior of having the back buffer scale to fit the window.

Or maybe the XAML presentation fixes that now? I don't know.

@nkast

This comment has been minimized.

Copy link
Contributor Author

commented Mar 10, 2017

I tested it on a desktop W8.1 (resize in windowed mode) and on the WP8.1 emulator (rotate it a few times).
I didn't see any issues.

Also tested it with this code in Game() (in WP8.1 & W10 emulator with fullscreen and rotate a couple of times)

            graphics.PreferredBackBufferWidth /= 4;
            graphics.PreferredBackBufferHeight /= 4;
            this.Window.ClientSizeChanged += (s, e) =>
            {
                graphics.PreferredBackBufferWidth /= 4;
                graphics.PreferredBackBufferHeight /= 4;
                graphics.ApplyChanges();
            };

Everything seems to work as it should. (except for another issue with touch)

@nkast nkast force-pushed the nkast:tnc_PreferredBackBufferWidth_Height_Swap branch from 9b7813a to 4b77cb4 Mar 18, 2017

@nkast nkast force-pushed the nkast:tnc_PreferredBackBufferWidth_Height_Swap branch from 4b77cb4 to ae2e338 May 29, 2017

@nkast nkast force-pushed the nkast:tnc_PreferredBackBufferWidth_Height_Swap branch from ae2e338 to f26ea96 Jun 6, 2017

@nkast nkast force-pushed the nkast:tnc_PreferredBackBufferWidth_Height_Swap branch from f26ea96 to bf07d7d Jun 21, 2017

Don't swap PreferredBackBufferWidth/Height
-also remove `_backBufferScale`

Fixes #5555

@nkast nkast force-pushed the nkast:tnc_PreferredBackBufferWidth_Height_Swap branch from bf07d7d to 95bde02 Jul 8, 2017

@nkast nkast closed this Sep 21, 2017

@nkast nkast deleted the nkast:tnc_PreferredBackBufferWidth_Height_Swap branch Sep 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.