New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix property content serialization detection when using a property named Item
.
#5996
Conversation
joncloud
commented
Oct 8, 2017
- Adjusts indexer property detection to check for Index Parameters instead of get/set method's parameters.
- Moves test compliation in order to share between tests.
- Creates new tests to verify changes.
…named `Item`. * Adjusts indexer property detection to check for Index Parameters instead of get/set method's parameters. * Moves test compliation in order to share between tests. * Creates new tests to verify changes.
I did notice that |
I should be able to look into the failing build checks today. I will need to setup locally to diagnose the failures. |
Resolved the build errors by rolling back C# syntax to a more compatible version. |
@joncloud - Thanks... i'll make sure this gets reviewed and merged here shortly. |
For a future PR it might be better for Don't see a huge need to split this all up. |
Got it - Do you want me to merge the two together on this PR, or setup another PR to do that? |
@joncloud - If you have the time and could do that in this PR it would be great. If not it can wait for another PR. |
OK I should be able to get the two merged on this PR. I just need to setup my test environment. |
Thanks @joncloud ! Merging! |
Item
.Item
.
…named `Item`. (MonoGame#5996) Fix property content serialization detection when using a property named `Item`.