Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix property content serialization detection when using a property named Item. #5996

Merged
merged 5 commits into from Mar 28, 2018
Merged

Fix property content serialization detection when using a property named Item. #5996

merged 5 commits into from Mar 28, 2018

Conversation

joncloud
Copy link
Contributor

@joncloud joncloud commented Oct 8, 2017

  • Adjusts indexer property detection to check for Index Parameters instead of get/set method's parameters.
  • Moves test compliation in order to share between tests.
  • Creates new tests to verify changes.

…named `Item`.

* Adjusts indexer property detection to check for Index Parameters instead of get/set method's parameters.
* Moves test compliation in order to share between tests.
* Creates new tests to verify changes.
@joncloud
Copy link
Contributor Author

joncloud commented Oct 8, 2017

I did notice that ReflectionHelpers.GetPropertySetMethod appeared to be no longer in use. I wasn't sure if I should remove it or not. Also ReflectionHelpers.GetPropertyGetMethod is only being used within the ReflectionHelpers type.

@joncloud
Copy link
Contributor Author

joncloud commented Oct 8, 2017

I should be able to look into the failing build checks today. I will need to setup locally to diagnose the failures.

@joncloud
Copy link
Contributor Author

joncloud commented Oct 8, 2017

Resolved the build errors by rolling back C# syntax to a more compatible version.

@tomspilman tomspilman added this to the 3.7 Release milestone Mar 27, 2018
@tomspilman
Copy link
Member

@joncloud - Thanks... i'll make sure this gets reviewed and merged here shortly.

@tomspilman
Copy link
Member

For a future PR it might be better for ArrayContentCompilerTest.cs and XmlContentCompilerTest.cs to be merged and moved into a new ContentCompilerTest.cs as that is what these both are.

Don't see a huge need to split this all up.

@tomspilman tomspilman self-requested a review March 27, 2018 04:55
@joncloud
Copy link
Contributor Author

Got it - Do you want me to merge the two together on this PR, or setup another PR to do that?

@tomspilman
Copy link
Member

@joncloud - If you have the time and could do that in this PR it would be great. If not it can wait for another PR.

@joncloud
Copy link
Contributor Author

OK I should be able to get the two merged on this PR. I just need to setup my test environment.

@tomspilman
Copy link
Member

Thanks @joncloud ! Merging!

@tomspilman tomspilman changed the title Fixes property content serialization detection when using a property named Item. Fix property content serialization detection when using a property named Item. Mar 28, 2018
@tomspilman tomspilman merged commit f1f30d0 into MonoGame:develop Mar 28, 2018
nkast pushed a commit to nkast/MonoGame that referenced this pull request May 6, 2018
…named `Item`. (MonoGame#5996)

Fix property content serialization detection when using a property named `Item`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants