Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #6732 - Exposes the instancing base index #6737

Open
wants to merge 3 commits into
base: develop
from

Conversation

@YTN0
Copy link
Contributor

YTN0 commented May 20, 2019

Per #6732 ... This change exposes the option to set the instance base index for instancing. This works perfectly on DirectX, and somewhat works on OpenGL. On OpenGL, this is still impacted by the instancing bug #6293.

Note: For OpenGL, if not setting the base instance index (which is the default behavior), it will continue using the original OpenGL API. If setting the base, this will use the OpenGL API glDrawElementsInstancedBaseInstance which is only available in OpenGL 4.2 and higher.

FYI @Jjagg

@YTN0

This comment has been minimized.

Copy link
Contributor Author

YTN0 commented May 20, 2019

FYI, protobuild isn't generating the web project, so I missed that in my initial checks. I did update that after the build failed... however it would be good to have the VS project for web also generated by protobuild so it isn't missed in any fixes / updates.

@YTN0

This comment has been minimized.

Copy link
Contributor Author

YTN0 commented Jun 19, 2019

Anyone have any thoughts on this PR? I am hoping this can get into 3.8....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.