Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright ligature (c) should be disabled #44

Closed
alexeyten opened this issue Nov 27, 2020 · 9 comments
Closed

Copyright ligature (c) should be disabled #44

alexeyten opened this issue Nov 27, 2020 · 9 comments

Comments

@alexeyten
Copy link

Version 1.6
https://www.monolisa.dev/playground

When I type (c) it becomes narrower than 3 chars thus changing alignment of the text.
Also this (artificial) example looks weird:

const charCodes = [...str].map((c) => c.charCodeAt(0));
const charCodes = [...str].map((a) => a.charCodeAt(0));

image

@bebraw
Copy link
Contributor

bebraw commented Nov 27, 2020

@MarcusSterz I guess this would be a good fit for a stylistic set? Keeping it enabled by default feels like the wrong choice for programming as the combination can come up in functions as in the example above.

@okonet
Copy link

okonet commented Nov 27, 2020

Thanks for reporting this! Yes, it should be put into a stylistic set.

@okonet
Copy link

okonet commented Nov 27, 2020

Hmm, I'm trying to reproduce it in my editor, but it works as expected:

CleanShot 2020-11-27 at 15 50 22@2x

Are you sure it's not a text substation of the OS kicking in?

@bebraw
Copy link
Contributor

bebraw commented Nov 27, 2020

I have the same in VS Code when ligatures are enabled:

Screen Shot 2020-11-27 at 16 02 52

I can also see the problem in the playground.

You may be right in that it's MacOS that's kicking in, though, as the replacement it's doing is fairly aggressive.

Likely the thing to do here would be to check if we've defined a ligature for (c) to begin with or is it something coming from elsewhere.

@alexeyten
Copy link
Author

My screenshot is from site’s playground in Firefox on Ubuntu

@MarcusSterz
Copy link

Yes, I can disable it and make it a stylistic set, no prob.

@MarcusSterz
Copy link

It is a common ligature trick. You normally add ligature-like features like this to make the workflow faster for people who write text.
I can delete it easily. Making it a stylistic set is not a good option since a stylistic set replaces a glyph with another. Here you have 3 glyphs being replaced by 1 symbol.

@okonet
Copy link

okonet commented Nov 28, 2020

Since we have a dedicated symbol for it I don't feel the need for it especially for developers.

Interesting question is why it's not reproducible for me on v1.600 on Mac neither in IDE nor on the website playground.

@okonet
Copy link

okonet commented Dec 4, 2020

We decided to drop the ligature but keep the symbol in the font.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants