New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the engine on a work in progress isn't a smooth process #22

Open
Tamakimouto opened this Issue Jul 24, 2016 · 5 comments

Comments

Projects
2 participants
@Tamakimouto
Contributor

Tamakimouto commented Jul 24, 2016

I suggest adding a .gitattributes with some merge driver lines so that
script.js index.html main.css main.js options.js
are excluded from merge, and maybe adding a "how to" in the readme/docs on updating the engine.

And perhaps a bit about gulp and the addons you're using too.

@Hyuchia

This comment has been minimized.

Member

Hyuchia commented Jul 24, 2016

The main.css main.js can be excluded, however the script.js index.html options.js files have changes that should be merged, I've never done this but I guess there is a way to add priority to some files over others, just not sure if that would work.

The documentation will be updated and I'll add the updating guide as well as the new features, gulp is mainly for the engine development but I'll add documentation of that as well.

@Hyuchia Hyuchia added the enhancement label Jul 24, 2016

@Hyuchia Hyuchia added this to the 1.3 milestone Jul 24, 2016

@Hyuchia

This comment has been minimized.

Member

Hyuchia commented Aug 7, 2016

After some thoughts, making it through git may not be exactly the best solution, neither through gulp, although they are good solutions, that leaves out many people, specially non-programmers, there probably is a need of a Builder, an application that allows you to create a new VN, handling the download of the files and everything, as well as the update of that VN, pretty much the way the Ren'py launcher works.

@Hyuchia Hyuchia removed this from the 1.3 milestone Aug 11, 2016

@Tamakimouto

This comment has been minimized.

Contributor

Tamakimouto commented Aug 16, 2016

A builder seems like an entire project on it's own. I've never used Renpy to know how it works, but if this builder you're talking about lets non-programmers essentially drag and drop a VN (select and manipulate character, action, scenes and fill in speech all from a GUI) frame by frame, that's definitely going to be a fairly long running project.

@Hyuchia

This comment has been minimized.

Member

Hyuchia commented Aug 22, 2016

Yeah, the problem would be the time to work on that. The issue with making the update smooth by git is that only people who use git would benefit from it, I wish it could be something more general.

@Hyuchia Hyuchia added this to To-Do in Monogatari v1.4 Jun 6, 2017

@Hyuchia Hyuchia moved this from To-Do to Postponed in Monogatari v1.4 Jan 31, 2018

@Hyuchia Hyuchia added this to Needs Design in Monogatari v2.0 May 19, 2018

@Hyuchia Hyuchia moved this from Needs Design to To do in Monogatari v2.0 Jul 11, 2018

@Hyuchia Hyuchia moved this from To do to In progress in Monogatari v2.0 Jul 13, 2018

@Hyuchia

This comment has been minimized.

Member

Hyuchia commented Jul 21, 2018

Ok so, after A LOT of time, I think this finally won't be an issue any more :) Given the current architecture being developed in the v2.0 branch, Monogatari now acts more as a library providing ways to expand it without having to modify its core engine. To update a game, one would simply need to change these files:

https://github.com/Monogatari/Monogatari/tree/v2.0/dist/engine

And that's it :D

@Hyuchia Hyuchia moved this from In progress to Done in Monogatari v2.0 Jul 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment