New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Action completion to report `.longRunning` and report final completion later #6

Closed
marcpalmer opened this Issue Apr 24, 2018 · 2 comments

Comments

Projects
None yet
1 participant
@marcpalmer
Contributor

marcpalmer commented Apr 24, 2018

At the moment the dispatcher will log if it takes too long to call completion, however we want to have some safeguard here to save people from forgetting to call completion, which is easily done.

So again look at returning a .longRunning outcome, which must be received quickly, and that will disable the detection of the missing completion, but we still expect it to call completion again later (we don't pass "longrunning" on to the caller") with failure or success.

@marcpalmer marcpalmer added this to the 1.0 milestone Apr 28, 2018

@marcpalmer

This comment has been minimized.

Show comment
Hide comment
@marcpalmer

marcpalmer Jul 19, 2018

Contributor

See #162 for the suggested solution using CompletionRequirement

Contributor

marcpalmer commented Jul 19, 2018

See #162 for the suggested solution using CompletionRequirement

@marcpalmer marcpalmer self-assigned this Jul 19, 2018

@marcpalmer

This comment has been minimized.

Show comment
Hide comment
@marcpalmer

marcpalmer Sep 2, 2018

Contributor

This was closed with the new CompletionRequirement work in #162.

  • TODO: Update all the docs
Contributor

marcpalmer commented Sep 2, 2018

This was closed with the new CompletionRequirement work in #162.

  • TODO: Update all the docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment