Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Revert Mozilla search engine handling. #699
https://bugzilla.mozilla.org/show_bug.cgi?id=1203167 changed the handling so the behavior is all sorts of a PITA for power users to deal with.
The rationale was: "Once the search cache is no longer optional (bug 1203161), we could use the cache file as the place to store user-installed engines."
This causes issues: The cache file is supposed to be just that: a (volatile) cache file for quick init of the search engines. If there's a problem in the json structure, not only does it fail to load, it will also be unrecoverable, leading to user data (added/custom search engines) being lost. In addition (and that is something I'd want to revert short-term), the custom lz4 compression on it makes it impossible to do anything with the file except from within an extension (that can use
Of note: a hash was also added to "prevent tampering" but that is exactly the kind of thing power users want to do to make quick edits to search plugin definitions. A hash should still be kept on the custom meta data so malicious parties can't change the search engine presence and order/keywords externally, but the engine definitions themselves don't need to be "guarded" or locked down this way.
Bottom line is it all becomes obscured and un-editable this way, unnecessarily so.
This change needs to be reverted, so we can get back to having a
Ahead of Pale Moon 28's release I want to include a slightly modified version of the
After which the "native" search service code can be purged.