Issues #816 / #802 - SpiderMonkey Tuneup #1192

g4jc · 2019-07-19T22:40:06Z

This is a large patch that rewrites the Parser and implements #816 (ES2019 Stringification) and #802 (Rest/Spread for Template Literals) in the Spider Monkey JavaScript engine.

…scapes.

… match "await SOMETHING" outside async function.

… out of Parser::functionStmt into Parser::consequentOrAlternative.

…children of if/else.

… Function constructor.

…ctionBox.

…'caller' on any of the new function types.

…s identical between syntax parsing and full parsing.

…urrent offset.

…fset.

…racedUnicode and make its signature fallible.

…integral number of chars to skip.

…ing EOF isn't yet hit and that newlines aren't skipped, if appropriate.

… it fails only when an underlying Vector::append fails, and that vector handles OOM reporting itself.

…liant.

… a parameter name.

…teral Restriction" ECMAScript proposal

…ay shapes.

Specifically, three changes: 1) valueOf should be non-enumerable. 2) valueOf should be === to Object.prototype.valueOf. 3) There should be no toJSON.

…esolvedLength to static method.

…ndFunctionArgument.

…ce error in object literal.

…racket error in array literal.

…literal parsing.

… longer needed.

…ores return value.

…ay literals.

…rties.

…ead properties.

…properties.

…ties are a thing.

…h are indices from frontend.

… in async function context.

This was a small mistake when converting from the `hasOwn()` function format (swapped parameters). Fixing this properly makes rest parameters exclude the parameters that are defined (which is the whole point of `...rest`

Fix order of OwnProperty check for rest parameters.

g4jc · 2019-07-19T22:48:42Z

Audit and reviews welcome. This is a large patch that fundamentally alters the javascript engine so we will need some aggressive testing on all applications and platforms.

While these are backports, there are several key differences:

We do not implement uneeded multi-threading. SpiderMonkey remains Single-Threaded. (Exclusivecontext)
We do not implement DOM Promise Changes, using existing UXP code instead. (promise->foo)
We do not implement CharT changes (<CharT>)
We do not implement IonMonkey changes for hasOwn, using OwnProperty check from existing codebase instead.

The logic behind these patches and their dependency tree was logged here:
https://ethercalc.org/vye88tn5c4en

If anyone needs assistance setting up a debug build I have other patches available which were not included in this push.

mattatobin · 2019-07-20T02:55:10Z

Could you please report how binoc-central or your own Hyperbola applications responds to this specifically mailnews?

wolfbeast · 2019-07-20T14:22:34Z

As additional background to this thread I have followed the patch progress, various re-bases and reworks of this code as WIP, and have kept a close eye on code in progress through private communication. Obviously, this needs investigation and extensive testing, but I would rather merge this in sooner rather than later to prevent any issues with code changes surrounding this, breaking the merge.

I suggest:
@adeshkp , @wicknix @mattatobin and myself make builds of this branch (in whatever UXP applications we want to focus on), check for obvious building/stability issues and report here if anything to report within the next 2 days. If good, bump the platform version, merge, toss it to the sharks on the unstable channel, and go from there.

mattatobin · 2019-07-20T17:26:53Z

General Javascript functionality and stability testing on Windows has gone very well for BinOC applications thus far.

@adeshkp or @wicknix could you provide me with a Macintosh build as soon as possible for the same testing?

mattatobin · 2019-07-20T20:25:01Z

The comm code paths and macintosh seem fully operational and stable, as does Windows. I am impressed and ecstatic. I think this is good to go to trunk and be shipped out on unstable!

Good work @g4jc!

@wolfbeast Platform bump and clobber just to be safe.

wicknix · 2019-07-20T20:36:34Z

Guess i'm 10 minutes late to the party. Just built uxp-816 and added the menu bar name space commit to this build. No issues to report. Can grab from here to test if need be.
[LINK REMOVED - Thanks]

wolfbeast · 2019-07-20T20:42:41Z

Awesome. Considering this good to throw to the sharks!

adeshkp · 2019-07-21T09:18:31Z

Very cool job pulled off by @g4jc
Great! 👏

g4jc added 30 commits Jun 8, 2019

1315815 - Don't treat async or await as a keyword when they contain e…

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

5e76f72

…scapes.

1317090: Remove js::FindBody;

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

dcb43bd

1317153 - Provide better error message when errornous syntax possibly…

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

f319f49

… match "await SOMETHING" outside async function.

1296814 - Move FunctionDeclaration-as-consequent/alternative handling…

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

987d672

… out of Parser::functionStmt into Parser::consequentOrAlternative.

1317379 - Disallow generator functions and async functions as direct …

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

7ecc50d

…children of if/else.

636635 - Do not create named lambda binding for a function created by…

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

986ae62

… Function constructor.

1320403 - Move JSFunction::EXPR_BODY to JSScript, LazyScript, and Fun…

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

90d999c

…ctionBox.

1325473 - A TypeError should be thrown when accessing 'arguments' or …

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

7535217

…'caller' on any of the new function types.

1325157 - Implement a ParserBase class that holds functionality that'…

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

c3e3a91

…s identical between syntax parsing and full parsing.

1326454 - Introduce TokenStream::error that reports an error at the c…

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

f6193fd

…urrent offset.

1326454 - Introduce TokenStream::warning that warns at the current of…

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

068916b

…fset.

1326454 - Rename TokenStream::getBracedUnicode to TokenStream::matchB…

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

b41de86

…racedUnicode and make its signature fallible.

1326454 - Make TokenStream::peekChar's signature fallible.

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

d400e94

1326454 - Make TokenStream::skipChars{,IgnoreEOL} accept an unsigned …

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

0ed4cf3

…integral number of chars to skip.

1326454 - Add assertions to TokenStream::skipChars{,IgnoreEOL} verify…

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

aa2decd

…ing EOF isn't yet hit and that newlines aren't skipped, if appropriate.

1325606 - Return wrapped async function from caller property.

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

af32c85

1323324 - Part 1: Make Promise::unforgeable{Resolve,Reject} spec-comp…

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

52e22e2

…liant.

1317374 - Don't do Annex B lexical function behavior when redeclaring…

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

adc81d6

… a parameter name.

1317375 - Implement "Template Literals Revision / Lifting Template Li…

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

afb28a4

…teral Restriction" ECMAScript proposal

903389 - Fix uses of ClassMethodIsNative.

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

668254e

903389 - Make Make NativeGet[Getter]PureInline handle dense/typed arr…

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

d074844

…ay shapes.

1333143 - Self-host Object.prototype.valueOf.

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

cefee26

1175823 - Implement [[DefineOwnProperty]] for mapped arguments object.

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

2ea840b

1175823 - Import test262 mapped arguments tests.

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

9476f2e

1320408 - Part 1: Change JSFunction::getLength and JSFunction::getUnr…

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

e5019fd

…esolvedLength to static method.

1320408 - Part 2: Change JSFunction::getOrCreateScript to static method.

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

739a819

1320408 - Part 3: Remove JSContext* parameter from JSFunction::getBou…

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

c2b1e70

…ndFunctionArgument.

1320408 - Part 4: Change JSObject::getGroup to static method.

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

af6768f

g4jc and others added 20 commits Jul 14, 2019

420857 - Part 3: Report the position of opening brace for missing bra…

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

10227d7

…ce error in object literal.

420857 - Part 4: Report the position of opening bracket for missing b…

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

e93a481

…racket error in array literal.

1303703 - Part 1: Separate binding pattern parsing from object/array …

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

b02f52f

…literal parsing.

1303703 - Part 2: Clean-up bits of destructuring parsing which are no…

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

55c897d

… longer needed.

1303703 - Part 3: Syntax parse destructuring assignment patterns.

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

a4b91b5

Refactor abortIfSyntaxParser after destructring

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

aa65e8a

1344477 - Part 1: Add JSOP_CALL_IGNORES_RV for function call that ign…

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

449ea84

…ores return value.

1344477 - Part 2: Optimize Array.prototype.splice with JSOP_NORVCALL.

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

85aeff7

1339395 - Part 1: Align parse method for object literals to match arr…

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

6444d5d

…ay literals.

Refactor Token& nextToken

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

638a904

1339395 - Part 2: Add parser support for rest and spread object prope…

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

091d00f

…rties.

1339395 - Part 3: Add BytecodeEmitter support for object rest and spr…

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

3048ff4

…ead properties.

1339395 - Part 5: Add Reflect.parse tests for object rest and spread …

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

262b119

…properties.

1339395 - Part 6: Update jit-tests now that object rest/spread proper…

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

8b4ee77

…ties are a thing.

1339395 - Part 7: Remove no longer needed check for jsid strings whic…

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

221239a

…h are indices from frontend.

1339395 - Part 8: Add separate variables for wasm debugger test.

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

076ad08

1344334 - Make DoTypeUpdateFallback infallible.

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

28c5b8c

1353691 - Report SyntaxError when arrow function has await-identifier…

Verified

This commit was signed with a verified signature.

g4jc

GPG key ID: AEAADD85D2F527B0 Learn about signing commits

4a84afd

… in async function context.

Merge pull request #1 from wolfbeast/patch-1

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

4a0061a

Fix order of OwnProperty check for rest parameters.

wolfbeast merged commit 779ef30 into MoonchildProductions:master Jul 20, 2019

MoonchildProductions / UXP

Issues #816 / #802 - SpiderMonkey Tuneup #1192

Issues #816 / #802 - SpiderMonkey Tuneup #1192

g4jc commented Jul 19, 2019 •

edited by wolfbeast

g4jc commented Jul 19, 2019 •

edited

mattatobin commented Jul 20, 2019 •

edited

wolfbeast commented Jul 20, 2019 •

edited

mattatobin commented Jul 20, 2019 •

edited

mattatobin commented Jul 20, 2019 •

edited

wicknix commented Jul 20, 2019 •

edited by mattatobin

wolfbeast commented Jul 20, 2019

adeshkp commented Jul 21, 2019

MoonchildProductions / UXP

Issues #816 / #802 - SpiderMonkey Tuneup #1192

Issues #816 / #802 - SpiderMonkey Tuneup #1192

Conversation

g4jc commented Jul 19, 2019 • edited by wolfbeast

g4jc commented Jul 19, 2019 • edited

mattatobin commented Jul 20, 2019 • edited

wolfbeast commented Jul 20, 2019 • edited

mattatobin commented Jul 20, 2019 • edited

mattatobin commented Jul 20, 2019 • edited

wicknix commented Jul 20, 2019 • edited by mattatobin

wolfbeast commented Jul 20, 2019

adeshkp commented Jul 21, 2019

g4jc commented Jul 19, 2019 •

edited by wolfbeast

g4jc commented Jul 19, 2019 •

edited

mattatobin commented Jul 20, 2019 •

edited

wolfbeast commented Jul 20, 2019 •

edited

mattatobin commented Jul 20, 2019 •

edited

mattatobin commented Jul 20, 2019 •

edited

wicknix commented Jul 20, 2019 •

edited by mattatobin