Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header height, icon size and target size #206

Merged
merged 10 commits into from Dec 3, 2019
Merged

Conversation

@NovacAndrei
Copy link
Contributor

NovacAndrei commented Dec 2, 2019

No description provided.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #206 into master will increase coverage by 0.05%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
+ Coverage   47.52%   47.57%   +0.05%     
==========================================
  Files         161      161              
  Lines        2060     2066       +6     
  Branches      428      431       +3     
==========================================
+ Hits          979      983       +4     
- Misses       1076     1078       +2     
  Partials        5        5
Flag Coverage Δ
#unittests 47.57% <77.77%> (+0.05%) ⬆️
Impacted Files Coverage Δ
...eens/send/components/account-list/account-list.tsx 10% <ø> (ø) ⬆️
src/screens/recover-wallet/styles.ts 100% <ø> (ø) ⬆️
...eens/account/components/account-settings/styles.ts 0% <ø> (ø) ⬆️
...creens/create-wallet-terms/create-wallet-terms.tsx 83.33% <ø> (ø) ⬆️
src/components/password-modal/password-modal.tsx 2.12% <ø> (ø) ⬆️
src/screens/transaction-details/styles.ts 0% <ø> (ø) ⬆️
src/components/header-left/styles.ts 100% <ø> (ø) ⬆️
src/screens/create-wallet-mnemonic/styles.ts 100% <ø> (ø) ⬆️
src/library/tab-select/styles.ts 100% <ø> (ø) ⬆️
src/screens/create-wallet-terms/styles.ts 100% <ø> (ø) ⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 998f534...b466dfb. Read the comment docs.

src/styles/dimensions.ts Outdated Show resolved Hide resolved
NovacAndrei added 2 commits Dec 2, 2019
@NovacAndrei NovacAndrei requested a review from krisboit Dec 2, 2019
NovacAndrei added 4 commits Dec 2, 2019
@krisboit krisboit merged commit 4bff13f into master Dec 3, 2019
8 checks passed
8 checks passed
Run checks
Details
codecov/changes No unexpected coverage changes found.
Details
codecov/patch 77.77% of diff hit (target 0%)
Details
codecov/project 47.57% (target 0%)
Details
security/snyk - android/app/build.gradle (Moonlet) No manifest changes detected
security/snyk - android/app/build.gradle (krisboit) No manifest changes detected
security/snyk - android/build.gradle (Moonlet) No manifest changes detected
security/snyk - package.json (Moonlet) No manifest changes detected
@krisboit krisboit deleted the header-height-icons-size branch Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.