feat: ✨ 移除 keyboard 虚拟键盘车牌号模式下不可用的 I、O 键 - #1037
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Walkthrough本次变更更新了车牌号虚拟键盘的常量定义和相关测试注释，明确说明并实现了字母 I 和 O 不再出现在车牌号键盘的字母区。仅涉及常量数组内容和注释的调整，未修改导出接口或其他逻辑。 Changes
Assessment against linked issues
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for wot-design-uni ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Walkthrough此PR重构了虚拟键盘的车牌号模式，移除了不符合车牌号规则的字母I和O。更新了键盘布局的注释和测试用例，以反映这些更改。 Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
|
|
||
| /** | ||
| * 车牌号键盘-数字和字母 | ||
| * 车牌号键盘-数字和字母（不包含I和O，因为车牌号规则中不使用这两个字母） |
There was a problem hiding this comment.
移除字母I和O是为了符合车牌号的规则，这样的更改是合理的。
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1037 +/- ##
==========================================
- Coverage 91.05% 89.70% -1.35%
==========================================
Files 10 15 +5
Lines 380 641 +261
Branches 61 81 +20
==========================================
+ Hits 346 575 +229
- Misses 34 66 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
组件测试摘要 (H5 平台)测试时间: Tue May 6 15:55:53 UTC 2025测试结果
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tests/components/wd-keyboard.test.ts (1)
258-271: 测试注释已更新，明确区分中文模式与字母模式
注释清楚描述了车牌模式下的两种状态，且指出字母模式下字母总数为 24（去除了 I、O），与常量定义保持一致。建议在测试中增加对切换到字母模式后按键数量（36 个）的断言，以进一步验证字母模式下键位渲染逻辑。
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/uni_modules/wot-design-uni/components/wd-keyboard/constants.ts(1 hunks)tests/components/wd-keyboard.test.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: Test Components (wd-keyboard)
- GitHub Check: Redirect rules - wot-design-uni
- GitHub Check: Header rules - wot-design-uni
- GitHub Check: Pages changed - wot-design-uni
- GitHub Check: Cloudflare Pages
🔇 Additional comments (1)
src/uni_modules/wot-design-uni/components/wd-keyboard/constants.ts (1)
44-44: 更新注释，清晰说明不包含 I 和 O 键
注释已准确说明车牌号键盘在字母模式下不使用字母 I 和 O，提高了可读性和维护性，与常量数组内容保持一致。
2 participants
✅ Closes: #1005
🤔 这个 PR 的性质是？(至少选择一个)
🔗 相关 Issue
#1005
💡 需求背景和解决方案
移除 keyboard 虚拟键盘车牌号模式下不可用的 I、O 键
☑️ 请求合并前的自查清单
Summary by CodeRabbit