Skip to content

fix: 🐛 修复 Fab 悬浮按钮组件 Icon 垂直居中异常的问题 - #1249

Merged
Moonofweisheng merged 1 commit into
masterfrom
fix/fab-icon-line-height
Aug 27, 2025
Merged

fix: 🐛 修复 Fab 悬浮按钮组件 Icon 垂直居中异常的问题#1249
Moonofweisheng merged 1 commit into
masterfrom
fix/fab-icon-line-height

Conversation

@Moonofweisheng

@Moonofweisheng Moonofweisheng commented Aug 27, 2025

Copy link
Copy Markdown
Owner

🤔 这个 PR 的性质是?(至少选择一个)

  • 日常 bug 修复
  • 新特性提交
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • CI/CD 改进
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 代码重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

修复 Fab 悬浮按钮组件 Icon 垂直居中异常的问题,取消 icon 组件默认的行高。

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充

Summary by CodeRabbit

  • 样式
    • 调整 wd-icon 基础样式:移除固定行高,改为使用默认/继承值。此变更可能影响图标与文本在同一行内的垂直对齐与间距效果,具体表现取决于所在容器与外层样式。在不同页面或主题下,图标的行内位置可能出现轻微变化;如需保持既有视觉一致性,可在项目中按需为相关位置补充行高或对齐样式。

@netlify

netlify Bot commented Aug 27, 2025

Copy link
Copy Markdown

Deploy Preview for wot-design-uni ready!

Name Link
🔨 Latest commit 4df9e8a
🔍 Latest deploy log https://app.netlify.com/projects/wot-design-uni/deploys/68aedc8304d1ce0008c454c0
😎 Deploy Preview https://deploy-preview-1249--wot-design-uni.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Aug 27, 2025

Copy link
Copy Markdown

Walkthrough

wd-icon 的基础样式中移除了 line-height: 1; 声明,未新增其他样式。该更改使图标行高回退为继承/默认值。

Changes

Cohort / File(s) Change Summary
样式调整:去除固定行高
src/uni_modules/wot-design-uni/components/wd-icon/index.scss
删除 line-height: 1;,保留其余图标基础样式不变;行高改为继承/默认

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 分钟

Poem

我把行高轻轻挪开,耳朵竖起看风来
字与图标并肩排,月光把边距铺开
咔哒一删不喧哗,样式随流更自在
兔子敲键心愉快,像素蹦跳到云霭

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between bdf279d and 4df9e8a.

📒 Files selected for processing (1)
  • src/uni_modules/wot-design-uni/components/wd-icon/index.scss (0 hunks)
💤 Files with no reviewable changes (1)
  • src/uni_modules/wot-design-uni/components/wd-icon/index.scss
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Cloudflare Pages
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/fab-icon-line-height

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vercel

vercel Bot commented Aug 27, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
wot-design-uni Ready Ready Preview Comment Aug 27, 2025 10:23am

@github-actions

Copy link
Copy Markdown

组件测试摘要 (H5 平台)

测试时间: Wed Aug 27 10:24:43 UTC 2025

测试结果

组件 状态 覆盖率
wd-icon ✅ 通过 100%

@Moonofweisheng
Moonofweisheng merged commit d7dac97 into master Aug 27, 2025
12 checks passed
@Moonofweisheng
Moonofweisheng deleted the fix/fab-icon-line-height branch August 27, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant