-
-
Notifications
You must be signed in to change notification settings - Fork 316
fix: 🐛 修复Textarea的placeholder无法设置空字符串问题 #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
👷 Deploy request for wot-design-uni pending review.Visit the deploys page to approve it
|
Walkthrough此次更改优化了 Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/uni_modules/wot-design-uni/components/wd-textarea/wd-textarea.vue (1 hunks)
Additional comments not posted (1)
src/uni_modules/wot-design-uni/components/wd-textarea/wd-textarea.vue (1)
20-20: 更改占位符逻辑以允许空字符串将占位符逻辑从逻辑或运算符
||修改为空值合并运算符??是一个明智的选择。这确保了占位符仅在明确为null或undefined时才回退到翻译后的默认值,而不是在遇到空字符串时。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/uni_modules/wot-design-uni/components/wd-textarea/wd-textarea.vue (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- src/uni_modules/wot-design-uni/components/wd-textarea/wd-textarea.vue
✅ Closes: #471
🤔 这个 PR 的性质是?(至少选择一个)
🔗 相关 Issue
#471
💡 需求背景和解决方案
更改判断方式,不再过滤空字符串
☑️ 请求合并前的自查清单
Summary by CodeRabbit
wd-textarea组件的占位符处理逻辑,确保有效的空字符串保留,而仅在占位符为null或undefined时回退到翻译函数,从而提升了用户体验。