fix: 🐛 col-picker 点击遮罩关闭执行两次#584
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Walkthrough此次更改主要集中在文档格式和结构的调整，特别是 Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for wot-design-uni ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- docs/component/col-picker.md (5 hunks)
- src/uni_modules/wot-design-uni/components/wd-action-sheet/wd-action-sheet.vue (1 hunks)
Files skipped from review due to trivial changes (1)
- docs/component/col-picker.md
Additional comments not posted (1)
src/uni_modules/wot-design-uni/components/wd-action-sheet/wd-action-sheet.vue (1)
130-132: 请注意handleClickModal函数的修改此次更改中，
handleClickModal函数中关闭模态框的逻辑被注释掉了。这一修改是为了解决点击遮罩关闭颜色选择器时触发关闭动作两次的问题。请确认此更改是否完全符合预期，并检查是否有其他副作用或回归问题。Verification successful
确认
handleClickModal函数的修改在
wd-action-sheet.vue文件中，handleClickModal函数的修改符合预期。该函数现在仅发出 'click-modal' 事件，而不会关闭模态框。这一更改符合 PR 的目标，即防止模态框在点击遮罩时关闭两次。请确保此更改符合预期行为，并检查是否有其他副作用或回归问题。
src/uni_modules/wot-design-uni/components/wd-action-sheet/wd-action-sheet.vue:handleClickModal函数仅发出 'click-modal' 事件。Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the `handleClickModal` function is only emitting 'click-modal' and not closing the modal. # Test: Search for the function usage. Expect: Only occurrences of the new signature. ast-grep --lang vue --pattern $'function handleClickModal() { $$$ emit("click-modal") $$$ }'Length of output: 206
Script:
#!/bin/bash # Search for the definition and usage of the `handleClickModal` function in the codebase. rg 'handleClickModal' -A 5Length of output: 2368
2 participants
🤔 这个 PR 的性质是？(至少选择一个)
🔗 相关 Issue
#569
💡 需求背景和解决方案
☑️ 请求合并前的自查清单
Summary by CodeRabbit
文档更新
col-picker组件的文档格式和结构，提升了可读性。cancel更改为close，以更准确地反映功能。功能变更
wd-action-sheet组件的行为，点击模态框时不再自动关闭，提供了更灵活的用户交互方式。