Skip to content

fix: 🐛 修复Input、Textarea未设置labelWidth时通过CSS变量设置label宽度无效的问题#591

Merged
Moonofweisheng merged 1 commit intomasterfrom
fix/input-label-width
Sep 10, 2024
Merged

fix: 🐛 修复Input、Textarea未设置labelWidth时通过CSS变量设置label宽度无效的问题#591
Moonofweisheng merged 1 commit intomasterfrom
fix/input-label-width

Conversation

@Moonofweisheng
Copy link
Owner

@Moonofweisheng Moonofweisheng commented Sep 10, 2024

Closes: #573

🤔 这个 PR 的性质是?(至少选择一个)

  • 日常 bug 修复
  • 新特性提交
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • CI/CD 改进
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 代码重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

Input、Textarea未设置labelWidth时通过CSS变量设置label宽度无效,原因是组件的props设置了默认值,会产生行内样式覆盖CSS变量。

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充

Summary by CodeRabbit

  • 新功能

    • 更新了输入组件和文本区域组件的 labelWidth 属性的默认值,改为不设置宽度,可能会影响组件的布局和样式表现。
  • 文档

    • 精简了文本区域组件的文档注释,去除了强调的符号,使文档更为简洁。

@vercel
Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wot-design-uni ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 5:03am

@coderabbitai
Copy link

coderabbitai bot commented Sep 10, 2024

Walkthrough

此次变更涉及对wd-inputwd-textarea组件的labelWidth属性的默认值进行修改,将其从'33%'更改为''(空字符串)。此外,还对wd-textarea的文档注释进行了简化,去除了部分强调符号。这些调整可能会影响组件的渲染和样式表现。

Changes

文件路径 变更摘要
src/uni_modules/wot-design-uni/components/wd-input/types.ts
src/uni_modules/wot-design-uni/components/wd-textarea/types.ts
修改labelWidth的默认值,从'33%'更改为''(空字符串);简化wd-textarea的文档注释。

Assessment against linked issues

Objective Addressed Explanation
希望cell的不设置左侧宽度的情况下,全局配置左侧宽度的样式优先级高于默认的行内样式。 (#573)

Possibly related issues

  • Moonofweisheng/wot-design-uni#480: 该问题提到在没有label属性时,下划线颜色加深,可能与labelWidth的默认值修改相关,影响组件样式表现。

兔子在草地上跳跃,
变化带来新气象,
标签宽度不再定,
空白处更显清爽。
组件样式焕然一新,
兔子欢呼声阵阵! 🐰✨

Tip

Announcements
  • The review status is no longer posted as a separate comment when there are no actionable or nitpick comments. In such cases, the review status is included in the walkthrough comment.
  • We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord.
  • Possibly related PRs: Walkthrough comment now includes a list of potentially related PRs to help you recall past context. Please share any feedback in the discussion post on our Discord.
  • Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs in the walkthrough comment. You can also provide custom labeling instructions in the UI or configuration file.
  • Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between dd2d99f and cfe065b.

Files selected for processing (2)
  • src/uni_modules/wot-design-uni/components/wd-input/types.ts (1 hunks)
  • src/uni_modules/wot-design-uni/components/wd-textarea/types.ts (1 hunks)
Additional comments not posted (4)
src/uni_modules/wot-design-uni/components/wd-input/types.ts (1)

128-128: 修改已批准。

labelWidth 属性的默认值从 '33%' 更改为 ''(空字符串),可以确保在未明确设置 labelWidth 时,标签宽度的 CSS 变量具有更高的优先级。这符合 PR 的目标。

src/uni_modules/wot-design-uni/components/wd-textarea/types.ts (3)

210-210: 文档修改已批准。

移除 label 属性文档注释中用于强调的星号,简化了文档。这一改动不会影响 label 属性的功能或用法。


216-216: 文档修改已批准。

移除 labelWidth 属性文档注释中用于强调的星号,简化了文档。这一改动不会影响 labelWidth 属性的功能或用法。


219-219: 修改已批准。

labelWidth 属性的默认值从 '33%' 更改为 ''(空字符串),可以确保在未明确设置 labelWidth 时,标签宽度的 CSS 变量具有更高的优先级。这符合 PR 的目标。


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@netlify
Copy link

netlify bot commented Sep 10, 2024

Deploy Preview for wot-design-uni ready!

Name Link
🔨 Latest commit cfe065b
🔍 Latest deploy log https://app.netlify.com/sites/wot-design-uni/deploys/66dfd311cc3e6c00080deac6
😎 Deploy Preview https://deploy-preview-591--wot-design-uni.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cloudflare-workers-and-pages
Copy link

Deploying wot-design-uni with  Cloudflare Pages  Cloudflare Pages

Latest commit: cfe065b
Status: ✅  Deploy successful!
Preview URL: https://5dc77f64.wot-design-uni.pages.dev
Branch Preview URL: https://fix-input-label-width.wot-design-uni.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug 上报] cell input 的css变量--wot-input-cell-label-width配置优先级低于默认的行内样式。

1 participant