Skip to content

feat: ✨ Input、Textarea增加ignoreCompositionEvent属性#592

Merged
Moonofweisheng merged 1 commit intomasterfrom
feature/input-ignoreCompositionEvent
Sep 10, 2024
Merged

feat: ✨ Input、Textarea增加ignoreCompositionEvent属性#592
Moonofweisheng merged 1 commit intomasterfrom
feature/input-ignoreCompositionEvent

Conversation

@Moonofweisheng
Copy link
Owner

@Moonofweisheng Moonofweisheng commented Sep 10, 2024 •
edited by coderabbitai bot
Loading

🤔 这个 PR 的性质是？(至少选择一个)

  • 日常 bug 修复
  • 新特性提交
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • CI/CD 改进
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 代码重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动（是关于什么的改动？）

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充

Summary by CodeRabbit

  • 新功能

    • 在输入组件和文本区域组件中新增了 ignoreCompositionEvent 属性，允许开发者控制是否忽略文本组合事件，从而提升输入体验。

  • 文档

    • 更新了输入组件和文本区域组件的文档，明确了新属性及现有属性的功能和默认值。

@vercel
Copy link

vercel bot commented Sep 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wot-design-uni ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 5:16am

@coderabbitai
Copy link

coderabbitai bot commented Sep 10, 2024 •
edited
Loading

Walkthrough

此次更改在输入组件中引入了一个新属性 ignoreCompositionEvent，该属性用于控制是否忽略文本组合事件。此更改适用于 wd-input 和 wd-textarea 组件，并在相关文档和类型定义中进行了相应更新，以提供更清晰的使用说明和默认值。此外，现有属性的描述也进行了小幅调整，以提高文档的可读性。

Changes

文件路径 更改摘要
docs/component/input.md 添加 ignoreCompositionEvent 属性，更新现有属性描述。
docs/component/textarea.md 添加 ignoreCompositionEvent 属性，更新现有属性描述。
src/uni_modules/wot-design-uni/components/wd-input/types.ts 添加 ignoreCompositionEvent 到 inputProps，更新现有属性描述。
src/uni_modules/wot-design-uni/components/wd-input/wd-input.vue 在 wd-input 组件中添加 ignoreCompositionEvent 属性。
src/uni_modules/wot-design-uni/components/wd-textarea/types.ts 添加 ignoreCompositionEvent 到 textareaProps，更新现有属性描述。
src/uni_modules/wot-design-uni/components/wd-textarea/wd-textarea.vue 在 wd-textarea 组件中添加 ignoreCompositionEvent 属性。

Possibly related issues

Poem

在草地上跳跃的小兔，
新功能来啦，真是美妙！
忽略组合事件，输入更顺畅，
快速输入不再失焦，
小小变化带来大不同，
兔子欢呼，乐在其中！ 🐇✨

Tip

Announcements
  • The review status is no longer posted as a separate comment when there are no actionable or nitpick comments. In such cases, the review status is included in the walkthrough comment.
  • We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord.
  • Possibly related PRs: Walkthrough comment now includes a list of potentially related PRs to help you recall past context. Please share any feedback in the discussion post on our Discord.
  • Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs in the walkthrough comment. You can also provide custom labeling instructions in the UI or configuration file.
  • Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).
Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2f12ac6 and 2093918.

Files selected for processing (6)
  • docs/component/input.md (1 hunks)
  • docs/component/textarea.md (1 hunks)
  • src/uni_modules/wot-design-uni/components/wd-input/types.ts (1 hunks)
  • src/uni_modules/wot-design-uni/components/wd-input/wd-input.vue (1 hunks)
  • src/uni_modules/wot-design-uni/components/wd-textarea/types.ts (1 hunks)
  • src/uni_modules/wot-design-uni/components/wd-textarea/wd-textarea.vue (1 hunks)
Additional comments not posted (8)
src/uni_modules/wot-design-uni/components/wd-input/types.ts (2)

172-172: 跳过评论

这是一个小的语法更改，不影响功能。

173-178: 代码更改已批准！

新属性 ignoreCompositionEvent 增强了输入组件的灵活性，允许开发人员更有效地管理文本合成事件。默认值 true 确保保留现有行为。

src/uni_modules/wot-design-uni/components/wd-textarea/types.ts (2)

285-285: 跳过评论

这是一个小的语法更改，不影响功能。

286-291: 代码更改已批准！

新属性 ignoreCompositionEvent 增强了文本域组件的灵活性，允许开发人员更有效地管理文本合成事件。默认值 true 确保保留现有行为。

docs/component/input.md (1)

175-175: 文档更改已批准！

文档更新准确反映了新的 ignoreCompositionEvent 属性，并提供了关于其行为的明确指导。默认值和版本信息已正确指定。

src/uni_modules/wot-design-uni/components/wd-textarea/wd-textarea.vue (1)

39-39: 新增 ignoreCompositionEvent 属性。

新增了一个名为 ignoreCompositionEvent 的布尔属性，用于控制是否忽略文本合成事件的处理。这个改动看起来没有问题。

src/uni_modules/wot-design-uni/components/wd-input/wd-input.vue (1)

45-45: 新增 ignoreCompositionEvent 属性。

新增了一个名为 ignoreCompositionEvent 的布尔属性，用于控制是否忽略文本合成事件的处理。这个改动看起来没有问题。

docs/component/textarea.md (1)

165-165: 为新增的 ignoreCompositionEvent 属性添加了文档说明。

文档中为新增的 ignoreCompositionEvent 布尔属性提供了清晰的说明，包括其功能、可选值以及默认值。文档更新没有问题。

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@netlify
Copy link

netlify bot commented Sep 10, 2024 •
edited
Loading

✅ Deploy Preview for wot-design-uni ready!

Name Link
🔨 Latest commit 2093918
🔍 Latest deploy log https://app.netlify.com/sites/wot-design-uni/deploys/66dfd5d5c8b38d000861f256
😎 Deploy Preview https://deploy-preview-592--wot-design-uni.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 10, 2024

Deploying wot-design-uni with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2093918
Status: ✅  Deploy successful!
Preview URL: https://23522875.wot-design-uni.pages.dev
Branch Preview URL: https://feature-input-ignorecomposit.wot-design-uni.pages.dev

View logs

@Moonofweisheng Moonofweisheng merged commit efcd4bb into master Sep 10, 2024
@Moonofweisheng Moonofweisheng deleted the feature/input-ignoreCompositionEvent branch September 10, 2024 05:21
This was referenced Dec 7, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Moonofweisheng